zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: bug with expansion and backslashes
Date: Sat, 15 Aug 2015 18:22:47 -0700	[thread overview]
Message-ID: <150815182247.ZM18309@torch.brasslantern.com> (raw)
In-Reply-To: <32312.1439680450@thecus.kiddle.eu>

On Aug 16,  1:14am, Oliver Kiddle wrote:
} Subject: bug with expansion and backslashes
}
} On 25 Apr, Bart wrote:
} > } >  add backslash to alias expansion matching in _expand
} > --- a/Completion/Base/Completer/_expand
} >    setopt aliases
} >    eval 'exp=( ${${(e)exp//\\[ 	
} > -]/ }//(#b)([ 	
} > +]/ }//(#b)([ 	\\
} >  ])/\\$match[1]} )' 2>/dev/null
} 
} I just noticed that expansion was broken when I tried to expand *\~
} (exiftran backs up files with a trailing ~ and I wanted to clean them up)
} git bisect led me to 33ff5d06 which is the patch above.
} 
} What's not clear to me is what problem this patch was trying to solve.

Look at workers/32186 which refers back to users/18247 and its thread.

It has to do with glob-expansion of file names that contain a character
that needs to be protected with a backslash, particularly file names
actually containing backslashes and/or quote marks.

(In other words, if you had attempted to complete "*~" without having
the backslash in there already, it would have worked and inserted the
backslash for you.)

I have no objection to backing out that change again, although it works
as expected when extendedglob is NOT set.


  reply	other threads:[~2015-08-16  1:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-15  3:05 broken parsing with $((`:`)) Mike Frysinger
2015-04-15  9:03 ` Peter Stephenson
2015-04-15 15:13   ` Bart Schaefer
2015-04-15 15:26     ` Peter Stephenson
2015-04-15 16:23       ` Potential 3.0.8 [was Re: broken parsing with $((`:`))] Bart Schaefer
2015-04-22  9:01         ` Peter Stephenson
2015-04-25 17:14           ` Pre-3.0.8 consolidated PATCH Bart Schaefer
2015-04-25 18:29             ` Axel Beckert
2015-04-25 18:46               ` FIVE-ZERO-EIGHT (was Re: Pre-3.0.8 consolidated PATCH) Bart Schaefer
2015-08-15 23:14             ` bug with expansion and backslashes Oliver Kiddle
2015-08-16  1:22               ` Bart Schaefer [this message]
2015-04-15 15:37     ` broken parsing with $((`:`)) Peter Stephenson
2015-04-15 16:13       ` Bart Schaefer
2015-04-15 16:31         ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=150815182247.ZM18309@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).