From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: broken parsing with $((`:`))
Date: Wed, 15 Apr 2015 10:03:24 +0100 [thread overview]
Message-ID: <20150415100324.296ffa3e@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <20150415030531.GA8187@vapier>
On Tue, 14 Apr 2015 23:05:31 -0400
Mike Frysinger <vapier@gentoo.org> wrote:
> looks like zsh doesn't correctly parse this:
> $ zsh -c 'echo $((`:`))'
> zsh:1: bad math expression: illegal character: \M-]
>
> looks like it's related to the subshell not outputting anything.
Yes, indeed --- there's a funny internal special case for empty strings
that I never quite get my head around.
(Please, God, make the problems with command and math substitution
parsing stop now.)
pws
diff --git a/Src/math.c b/Src/math.c
index c047725..f2c72d5 100644
--- a/Src/math.c
+++ b/Src/math.c
@@ -1398,7 +1398,7 @@ matheval(char *s)
if (!mlevel)
outputradix = outputunderscore = 0;
- if (!*s) {
+ if (!*s || *s == Nularg) {
x.type = MN_INTEGER;
x.u.l = 0;
return x;
diff --git a/Test/C01arith.ztst b/Test/C01arith.ztst
index d3176dd..e2dfe56 100644
--- a/Test/C01arith.ztst
+++ b/Test/C01arith.ztst
@@ -383,4 +383,7 @@
print ${$(( $1 * 100 ))%%.[0-9]#})
0:Arithmetic substitution nested in parameter substitution
>3246
-
+
+ print $((`:`))
+0:Null string in arithmetic evaluation after command substitution
+>0
next prev parent reply other threads:[~2015-04-15 9:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 3:05 Mike Frysinger
2015-04-15 9:03 ` Peter Stephenson [this message]
2015-04-15 15:13 ` Bart Schaefer
2015-04-15 15:26 ` Peter Stephenson
2015-04-15 16:23 ` Potential 3.0.8 [was Re: broken parsing with $((`:`))] Bart Schaefer
2015-04-22 9:01 ` Peter Stephenson
2015-04-25 17:14 ` Pre-3.0.8 consolidated PATCH Bart Schaefer
2015-04-25 18:29 ` Axel Beckert
2015-04-25 18:46 ` FIVE-ZERO-EIGHT (was Re: Pre-3.0.8 consolidated PATCH) Bart Schaefer
2015-08-15 23:14 ` bug with expansion and backslashes Oliver Kiddle
2015-08-16 1:22 ` Bart Schaefer
2015-04-15 15:37 ` broken parsing with $((`:`)) Peter Stephenson
2015-04-15 16:13 ` Bart Schaefer
2015-04-15 16:31 ` Peter Stephenson
2015-04-17 4:39 Mikael Magnusson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150415100324.296ffa3e@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).