From: Bart Schaefer <schaefer@brasslantern.com>
To: Axel Beckert <abe@deuxchevaux.org>, zsh-workers@zsh.org
Subject: Re: Testsuite failures in A05execution inside Jenkins, but not locally (was: zsh 5.0.8.-test-3)
Date: Wed, 26 Aug 2015 11:07:02 -0700 [thread overview]
Message-ID: <150826110702.ZM23706@torch.brasslantern.com> (raw)
In-Reply-To: <20150826135819.GO9970@sym.noone.org>
On Aug 26, 3:58pm, Axel Beckert wrote:
}
} But I had test suite failures when being build inside a Jenkins job.
} Doesn't seem to be caused by the zsh updated though as the most recent
} 5.0.8 build failed at the very same test:
}
} + (eval):printf:4: write error: broken pipe
} + (eval):4: write error: inappropriate ioctl for device
} + cat: write error: Broken pipe
} + hang:printf: write error: broken pipe
} + hang: write error: inappropriate ioctl for device
} Was testing: Bug regression: piping a shell construct to an external process may hang
Those broken pipe errors are irrelevant to the test (in fact they're the
expected reason for the printf and cat processes to terminate, but under
normal circumstances that doesn't print an error). So I think we can
safely throw them away.
Consequently, does this fix it?
diff --git a/Test/A05execution.ztst b/Test/A05execution.ztst
index d5501bb..d9e6409 100644
--- a/Test/A05execution.ztst
+++ b/Test/A05execution.ztst
@@ -207,7 +207,7 @@ F:This similar test was triggering a reproducible failure with pipestatus.
coproc { read -et 5 || { print -u $ZTST_fd KILLED; kill -HUP -$$ } }
print -u $ZTST_fd 'This test takes 5 seconds to fail...'
{ printf "%d\n" {1..20000} } | ( read -e )
- hang(){ printf "%d\n" {2..20000} | cat }; hang | ( read -e )
+ hang(){ printf "%d\n" {2..20000} | cat }; hang 2>/dev/null | ( read -e )
print -p done
read -et 6 -p
0:Bug regression: piping a shell construct to an external process may hang
next prev parent reply other threads:[~2015-08-26 18:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150825194807.194b3bed@ntlworld.com>
2015-08-26 13:58 ` Axel Beckert
2015-08-26 18:07 ` Bart Schaefer [this message]
2015-08-27 13:47 ` Axel Beckert
2015-08-27 14:14 ` Axel Beckert
2015-08-27 16:12 ` Bart Schaefer
2015-08-28 11:41 ` zsh 5.0.8.-test-3 Axel Beckert
2015-08-28 17:44 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150826110702.ZM23706@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=abe@deuxchevaux.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).