From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Frank Terbeck <ft@bewatermyfriend.org>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH 2/2] vcs_info git: For the branch name, try to find a symbolic name before falling back to a raw commit hex.
Date: Mon, 20 Aug 2018 13:02:15 +0000 [thread overview]
Message-ID: <1534770135.103410.1479921056.7CBC27FA@webmail.messagingengine.com> (raw)
In-Reply-To: <87r2itmfc3.fsf@ft.bewatermyfriend.org>
Frank Terbeck wrote on Mon, 20 Aug 2018 13:45 +0200:
> Daniel Shahaf wrote:
> > 1. Adding knobs induces a maintenance cost going forward. Is that cost
> > justified in this case? We can always add the knob later if there's
> > demand for it, but it's harder to take away behaviour once it has
> > been released.
> >
> > 2. At what point in the if-chain do we raise the white flag^W^W^W^W
> > check the "early exit?" style?
> >
> > I suppose we could overload the `use-simple` style for this purpose (the
> > git backend doesn't currently use that style). The `get-revision` style
> > is also relevant.
>
> Yeah. The git backend is pretty complex as it is. Maybe it's not worth
> it, to make this configurable. I don't know.
Let's leave the style out until/unless someone asks for it. It'd be trivial to add
later if we want it.
prev parent reply other threads:[~2018-08-20 13:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-18 15:57 [PATCH 1/2] vcs_info git: Flatten a nested if Daniel Shahaf
2018-08-18 15:57 ` [PATCH 2/2] vcs_info git: For the branch name, try to find a symbolic name before falling back to a raw commit hex Daniel Shahaf
2018-08-18 20:41 ` Frank Terbeck
2018-08-19 12:32 ` Daniel Shahaf
2018-08-20 11:45 ` Frank Terbeck
2018-08-20 13:02 ` Daniel Shahaf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1534770135.103410.1479921056.7CBC27FA@webmail.messagingengine.com \
--to=d.s@daniel.shahaf.name \
--cc=ft@bewatermyfriend.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).