Bug in bracketed-paste-magic?

Bug in bracketed-paste-magic?

[Eric Freese]

[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]

Hi,

I'm developing an autosuggest plugin at
https://github.com/tarruda/zsh-autosuggestions and have been looking into
an issue (#102 in that repo) that occurs when bracketed-paste-magic is
enabled. I've tracked it down to the `bracketed-paste-magic` function
making a call to `zle` without the `-w` flag. It seems to me this is a bug
in bracketed-paste-magic- that it should be using the `-w` flag to set
$WIDGET and associated parameters when invoking a possibly user-defined
widget. Would adding the `-w` flag here possibly break anything else?

I'm not very familiar with the best way to get this patched, but I've
forked the repo on GitHub and pushed a commit that adds the `-w` flag. It's
available at
https://github.com/ericfreese/zsh/commit/ff23295570e477a6f4b4c1c1e0f97eddc277bcd9

The relevant github issue for my plugin:
https://github.com/tarruda/zsh-autosuggestions/issues/102

Cheers,
Eric Freese

P.S. Another concern (though it's really a separate issue) is the `zle
undo` later in the file. Shouldn't that be `zle .undo` to avoid any
potential problems arising from the `undo` widget being overridden by a
user-defined widget?

Re: Bug in bracketed-paste-magic?

[Bart Schaefer]

On Feb 13,  8:42pm, Eric Freese wrote:
}
} making a call to `zle` without the `-w` flag. It seems to me this is a bug

Just for zsh-workers reference, here is the patch:

diff --git a/Functions/Zle/bracketed-paste-magic
b/Functions/Zle/bracketed-paste-magic
index 2b2bc63..498cf55 100644
--- a/Functions/Zle/bracketed-paste-magic
+++ b/Functions/Zle/bracketed-paste-magic
@@ -175,7 +175,7 @@ bracketed-paste-magic() {
 		case $REPLY in
 		    (${~bpm_active}) function () {
 			emulate -L $bpm_emulate; set -$bpm_opts
-			zle $REPLY
+			zle $REPLY -w
 		    };;
 		    (*) zle .self-insert;;
 		esac
@@ -184,7 +184,7 @@ bracketed-paste-magic() {
 	PASTED=$BUFFER
 
 	# Reset the undo state
-	zle undo $bpm_undo
+	zle .undo $bpm_undo
 	UNDO_LIMIT_NO=$bpm_limit
 
 	zle -K $bpm_keymap