From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: compset -q oddities
Date: Wed, 14 Sep 2016 09:04:57 -0700 [thread overview]
Message-ID: <160914090457.ZM29602@torch.brasslantern.com> (raw)
In-Reply-To: <20160914093146.08a2c090@pwslap01u.europe.root.pri>
On Sep 14, 9:31am, Peter Stephenson wrote:
} Subject: Re: compset -q oddities
}
} On Tue, 13 Sep 2016 22:20:29 -0700
} Bart Schaefer <schaefer@brasslantern.com> wrote:
} > Well, no, not really. "compset -q" should make note that there were
} > no quotes when it was called, and therefore not restore any quote on
} > the way back out. There's a comment above compcore.c:307
} >
} > /*
} > * It looks like we may need to do stuff with backslashes even
} > * if instring is QT_NONE.
} > */
}
} I think the point is related to the fact that in the case of backslashes
} we never know there are no quotes.
Aha. So if we see a word that starts with backslash, instring will be
QT_BACKSLASH, but when instring is QT_NONE, we do not know whether any
other backslashes appear in the middle of the word.
However, as I said in a previous reply:
>> The problem isn't really with the backslash being added there, it's
>> somewhere later on when the prefix is being compared to the candidate
>> match and one side of gets too much (? different?) quoting before the
>> comparison is made.
That later stage [wherever it is, I suspect comp_match()] also expects
that quoting has been manipulated in this way, and so if it has *not*
(I played with compcore.c:307) then strings that should match, do not.
The problem is that we have [at least] three sources of data: The
literal command line, the (possibly quoting-manipulated) subset of
the command line against which completion is being attempted, and the
candidate matches passed to compadd. Canonicalizing in a way that
makes it possible to compare any two of the three is very difficult.
prev parent reply other threads:[~2016-09-14 16:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-11 7:30 Daniel Shahaf
2016-09-12 2:14 ` Bart Schaefer
2016-09-12 23:06 ` Daniel Shahaf
2016-09-13 6:28 ` Bart Schaefer
2016-09-13 10:21 ` Peter Stephenson
2016-09-14 17:56 ` Bart Schaefer
2016-09-15 5:10 ` Daniel Shahaf
2016-09-16 0:40 ` Bart Schaefer
2016-09-16 3:05 ` [PATCH] Etc/BUGS: Remove fixed items, add 'compset -q' item from workers/39306 Daniel Shahaf
2016-09-16 5:00 ` Bart Schaefer
2016-09-14 3:22 ` compset -q oddities Daniel Shahaf
2016-09-14 5:20 ` Bart Schaefer
2016-09-14 6:12 ` Daniel Shahaf
2016-09-14 14:59 ` Bart Schaefer
2016-09-14 19:52 ` Oliver Kiddle
2016-09-15 3:08 ` Bart Schaefer
2016-09-14 8:31 ` Peter Stephenson
2016-09-14 16:04 ` Bart Schaefer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160914090457.ZM29602@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).