From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: compset -q oddities
Date: Wed, 14 Sep 2016 06:12:52 +0000 [thread overview]
Message-ID: <20160914061252.GA22452@fujitsu.shahaf.local2> (raw)
In-Reply-To: <160913222029.ZM13117@torch.brasslantern.com>
Bart Schaefer wrote on Tue, Sep 13, 2016 at 22:20:29 -0700:
> On Sep 14, 3:22am, Daniel Shahaf wrote:
> } Subject: Re: compset -q oddities
> }
> } Bart Schaefer wrote on Mon, Sep 12, 2016 at 23:28:53 -0700:
> } > You didn't start from ~~~. You started from an empty word and typed
> } > TAB twice. ~~~ was never on the line. I concur that the result of
> } > the second attempt is weird, I would have expected it just to fail.
> }
> } I would have expected the second <TAB> press to do nothing
>
> If the first tab had correctly produced one of ~~~ or \~\~\~ then I
> would have expected the second tab to do nothing, but given what the
> first tab incorrectly burped out, it should have failed.
Why should «f \\\~\\\~\\\~<TAB>» fail?
«ssh \git.code<TAB>» completes to "ssh git.code.sf.net" despite the
redundant backslash.
By analogy, when 'compset -q' is _not_ involved, if "~~~" is a match
then «\~\~\~<TAB>» should complete to it. (Although it might in fact
complete to \~\~\~ because of the quotestring() issue discussed below.)
Since a \~\~\~ word matches a '~~~' completion when 'compset -q' is not
involved, therefore a \\\~\\\~\\\~ word should match a '~~~' completion
when 'compset -q' _is_ in effect.
Essentially, 'compset -q' "looks through" one level of quoting, and
whatever is happening in the «ssh \git.code<TAB>» case looks through the
second level of quoting.
Makes sense?
> Also now that I think of it, there's only one match with that compadd,
> so it should have appended a trailing space and the second tab should
> have been in an entirely new (also empty) word.
That's a bit tricky. I think it should append an escaped space, e.g.,
«sh -c touc<TAB>» should append <h> <Backslash> <Space>.
Then there are use-cases such as «su -c script-without-arguments.<TAB>»
where one wants to run «su -c script-without-arguments.foobar» (without
further arguments), which make me think that backslash-escaped should be
autoremovable.
Perhaps something like this, for «sh -c ech<TAB>»:
1) <h> <Backslash> <Space> is inserted.
2) If the user types an alphanumeric, the backslash-space is kept (stops
being autoremovable) and the alphanumeric is inserted as the start of
the second argument to 'echo'.
3) If the user types a space, the backslash-space changed to
space (to close the argument to the top-level -c option).
All this assumes the "compset -q"'d argument is backslash-quoted. It'd
be slightly different if it uses single or double quotes («sh -c
'ech<TAB>»).
> } This makes sense as far as quotestring() is concerned, but when called
> } from completion, this causes the tilde to be quoted even though
> } ${_comp_caller_options[extendedglob]} is unset.
>
> Indeed. It might make sense for the internals to save the top-level
> option state on entry and implicitly re-assert it during compadd.
>
Not only compadd, but all the other comp* builtins too, no?
> } Perhaps making quotestring() not add that redundant first
> } backslash would workaround the issue
>
> The problem isn't really with the backslash being added there, it's
> somewhere later on when the prefix is being compared to the candidate
> match and one side of gets too much (? different?) quoting before the
> comparison is made. I haven't figured out where that is, yet (and am
> not going to try too hard, honestly).
Fair enough :-)
Cheers,
Daniel
next prev parent reply other threads:[~2016-09-14 6:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-11 7:30 Daniel Shahaf
2016-09-12 2:14 ` Bart Schaefer
2016-09-12 23:06 ` Daniel Shahaf
2016-09-13 6:28 ` Bart Schaefer
2016-09-13 10:21 ` Peter Stephenson
2016-09-14 17:56 ` Bart Schaefer
2016-09-15 5:10 ` Daniel Shahaf
2016-09-16 0:40 ` Bart Schaefer
2016-09-16 3:05 ` [PATCH] Etc/BUGS: Remove fixed items, add 'compset -q' item from workers/39306 Daniel Shahaf
2016-09-16 5:00 ` Bart Schaefer
2016-09-14 3:22 ` compset -q oddities Daniel Shahaf
2016-09-14 5:20 ` Bart Schaefer
2016-09-14 6:12 ` Daniel Shahaf [this message]
2016-09-14 14:59 ` Bart Schaefer
2016-09-14 19:52 ` Oliver Kiddle
2016-09-15 3:08 ` Bart Schaefer
2016-09-14 8:31 ` Peter Stephenson
2016-09-14 16:04 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914061252.GA22452@fujitsu.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).