From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: Off-by-one with select-*-shell-word text object?
Date: Mon, 19 Sep 2016 08:19:53 -0700 [thread overview]
Message-ID: <160919081953.ZM28145@torch.brasslantern.com> (raw)
In-Reply-To: <47450.1474279314@hydra.kiddle.eu>
On Sep 19, 12:01pm, Oliver Kiddle wrote:
}
} You've got to force set_bindk to either 1 or 0 and my guess is that
} a future widget is more likely to want 1 than to want 0. Even with
} a new bitmask flag, I'd sooner opt for it having the opposite sense
} to what you suggest.
}
} Daniel Shahaf wrote:
} > That's why I suggested to invent a new bitmask flag that implies
} > set_bindk on a per-widget basis: the property 'requires $WIDGET to
} > be self-referential' does not follow from 'is implemented in C'.
My somewhat related point is that UNLESS we're going to add an option
to "zle -N"/"zle -C" to control that new bitmask flag for user-defined
widgets, the unusual and therefore flag-worthy case applies only with
respect to builtins, and therefore is "requires $WIDGET to be caller-
referential."
} [aside: if anyone relied on it for run-help/which-command to invoke
} their own command, they should use zle -A].
This might be worth documenting. It might have to be paired with
"zle .run-help" or similar?
} getvirange() is more concerned with the keys that were used than
} with the identify of the widget. That's why I'd sooner regard it
} as bindk that is overloaded.
Indeed, "bindkey -a z vi-change" makes "cc" "cz" and "zc" synonymous.
} I don't think adding another variable like $WIDGET is a good idea.
It'd need to be a $LASTKEYS to go with $LASTWIDGET, if anything.
prev parent reply other threads:[~2016-09-19 15:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 17:21 Bart Schaefer
2016-09-16 20:47 ` Oliver Kiddle
2016-09-16 21:22 ` Bart Schaefer
2016-09-16 23:30 ` Oliver Kiddle
2016-09-17 3:02 ` Bart Schaefer
2016-09-17 7:42 ` Daniel Shahaf
2016-09-17 14:29 ` Bart Schaefer
2016-09-19 7:00 ` Daniel Shahaf
2016-09-19 10:01 ` Oliver Kiddle
2016-09-19 15:19 ` Bart Schaefer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160919081953.ZM28145@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).