From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: Off-by-one with select-*-shell-word text object?
Date: Sat, 17 Sep 2016 07:42:59 +0000 [thread overview]
Message-ID: <20160917074259.GA26221@fujitsu.shahaf.local2> (raw)
In-Reply-To: <160916200205.ZM27241@torch.brasslantern.com>
Bart Schaefer wrote on Fri, Sep 16, 2016 at 20:02:05 -0700:
> On Sep 17, 1:30am, Oliver Kiddle wrote:
> } run-help, which-command and zap-to-char suffer from the same
> } issue as the text object widgets: they use bindk to select their
> } behaviour.
> }
> } So any thoughts on this solution?
>
> I'd probably write it as an assignment of setbindk rather than put the
> whole expression in the execzlefunc argument, but otherwise this seems
> sensible on the face of it.
I think it would be cleaner to invent a new bitmask flag and set it on
the affected widgets (select-*-word, run-help, etc) than to overload
WIDGET_INT for this purpose.
Whether a widget is implemented in C or in shell has no bearing on
whether it assumes that $WIDGET points to itself.
Cheers,
Daniel
next prev parent reply other threads:[~2016-09-17 7:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 17:21 Bart Schaefer
2016-09-16 20:47 ` Oliver Kiddle
2016-09-16 21:22 ` Bart Schaefer
2016-09-16 23:30 ` Oliver Kiddle
2016-09-17 3:02 ` Bart Schaefer
2016-09-17 7:42 ` Daniel Shahaf [this message]
2016-09-17 14:29 ` Bart Schaefer
2016-09-19 7:00 ` Daniel Shahaf
2016-09-19 10:01 ` Oliver Kiddle
2016-09-19 15:19 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160917074259.GA26221@fujitsu.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).