zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Cc: danielsh@apache.org
Subject: Re: zsh/complist colours improperly handle multibyte characters
Date: Fri, 21 Oct 2016 08:48:29 -0700	[thread overview]
Message-ID: <161021084829.ZM8719@torch.brasslantern.com> (raw)
In-Reply-To: <20161021093355.2fc2058b@pwslap01u.europe.root.pri>

On Oct 21,  9:33am, Peter Stephenson wrote:
}
} Yes, unfortunately character-by-character analysis is built into
} completion at quite a low level.

I think this particular issue may be a lot more tractible than you
believe.  clnicezputs() already has the MULTIBYTE_SUPPORT branch
that seems also to be needed by clprintfmt() -- I could probably
make an attempt to translate, but someone who has actually worked
with e.g. ZMB_nicewidth() and re-composing of bytes into multibyte
characters could probably do it faster.

The other part seems a plain pattern compilation issue.  Neither of
these gets involved with comparing strings on the line to strings
in the candidates.  This is all on the tail end where we already
have the matches and we're displaying them.


      reply	other threads:[~2016-10-22  1:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20161021011017eucas1p1d1fceae920242e69b4426bc41cb3c064@eucas1p1.samsung.com>
2016-10-21  1:09 ` Danielle McLean
2016-10-21  4:07   ` Bart Schaefer
2016-10-23 17:30     ` Peter Stephenson
2016-10-23 18:23       ` Bart Schaefer
     [not found]     ` <20161023184641.4549e10a@ntlworld.com>
     [not found]       ` <161023105652.ZM3309@torch.brasslantern.com>
2016-10-23 18:59         ` Peter Stephenson
2016-10-23 19:34           ` Bart Schaefer
2016-10-25 10:44             ` Peter Stephenson
2016-10-25 15:59               ` Bart Schaefer
2016-10-25 16:05                 ` Peter Stephenson
2016-10-21  8:33   ` Peter Stephenson
2016-10-21 15:48     ` Bart Schaefer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161021084829.ZM8719@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=danielsh@apache.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).