From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: zsh/complist colours improperly handle multibyte characters
Date: Sun, 23 Oct 2016 19:59:08 +0100 [thread overview]
Message-ID: <20161023195908.40edc8cf@ntlworld.com> (raw)
In-Reply-To: <161023105652.ZM3309@torch.brasslantern.com>
On Sun, 23 Oct 2016 10:56:52 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> [This is off-list, did you mean to?]
No, that was just stuipdity.
> On Oct 23, 6:46pm, Peter Stephenson wrote:
> } Subject: Re: zsh/complist colours improperly handle multibyte characters
> }
> } On Thu, 20 Oct 2016 21:07:35 -0700
> } Bart Schaefer <schaefer@brasslantern.com> wrote:
> } > Stepping through with gdb for the vertical-bar pattern, I get:
> } >
> } > pattern.c:1530: BUG: - missing from numeric glob
> }
> } Sounds like they're being treated as pattern characters when that's not
> } what you want?
>
> No, sorry, this is a UTF-8 full-line-height vertical-bar, not ascii pipe.
> It's incorrectly interpreted as a left angle bracket pattern character,
> if that BUG message is accurate.
Ah, then there's a good chance this is indeed a problem with
zshtokenize. We probably ought at least to pass through metafied
characters. I don't know that fits this particular case, but it's the
obvious problem.
pws
diff --git a/Src/glob.c b/Src/glob.c
index a845c5f..0442bbf 100644
--- a/Src/glob.c
+++ b/Src/glob.c
@@ -3499,6 +3499,10 @@ zshtokenize(char *s, int flags)
for (; *s; s++) {
cont:
switch (*s) {
+ case Meta:
+ /* skip Meta as well as following character */
+ s++;
+ break;
case Bnull:
case Bnullkeep:
case '\\':
next prev parent reply other threads:[~2016-10-23 18:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161021011017eucas1p1d1fceae920242e69b4426bc41cb3c064@eucas1p1.samsung.com>
2016-10-21 1:09 ` Danielle McLean
2016-10-21 4:07 ` Bart Schaefer
2016-10-23 17:30 ` Peter Stephenson
2016-10-23 18:23 ` Bart Schaefer
[not found] ` <20161023184641.4549e10a@ntlworld.com>
[not found] ` <161023105652.ZM3309@torch.brasslantern.com>
2016-10-23 18:59 ` Peter Stephenson [this message]
2016-10-23 19:34 ` Bart Schaefer
2016-10-25 10:44 ` Peter Stephenson
2016-10-25 15:59 ` Bart Schaefer
2016-10-25 16:05 ` Peter Stephenson
2016-10-21 8:33 ` Peter Stephenson
2016-10-21 15:48 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161023195908.40edc8cf@ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).