zsh-workers
 help / color / mirror / code / Atom feed
* expandorcompleteprefix patch
@ 1996-05-01 17:22 Michael Pitman
  1996-05-01 21:01 ` Zoltan Hidvegi
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Pitman @ 1996-05-01 17:22 UTC (permalink / raw)
  To: zsh-workers%math.gatech.edu

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

Here is a very small patch to fix expand-or-complete-prefix when in automenu
mode (prob also in menucomplete mode too).

This comletion mechanism hasn't worked for a while, but I only just got around
to fixing it.  No idea how to properly submit patches, so I'm just going to
send to this mailing list with the hope that it's added.

Patch applies to zsh-2.6-beta15

Bye.
_______________________________________________
Michael Pitman <mp@marvin.jpl.oz.au>
Electrical Engineer, Otis Building Technologies

[-- Attachment #2: zsh2615.patch --]
[-- Type: text/plain, Size: 542 bytes --]

diff -u zsh-2.6-beta15orig/Src/zle_tricky.c zsh-2.6-beta15/Src/zle_tricky.c
--- zsh-2.6-beta15orig/Src/zle_tricky.c	Thu Apr 25 13:25:41 1996
+++ zsh-2.6-beta15/Src/zle_tricky.c	Wed May  1 11:54:10 1996
@@ -4002,10 +4002,12 @@
 {
     /* global c is the current character typed. */
     int csafe = c;
+    int menusafe = menucmp;
 
     /* insert a space and backspace. */
     c = ' ';
     selfinsert();		/* insert the extra character */
+    menucmp = menusafe;
     forwardchar();		/* move towards beginning */
     
     remove_at = cs;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: expandorcompleteprefix patch
  1996-05-01 17:22 expandorcompleteprefix patch Michael Pitman
@ 1996-05-01 21:01 ` Zoltan Hidvegi
  0 siblings, 0 replies; 2+ messages in thread
From: Zoltan Hidvegi @ 1996-05-01 21:01 UTC (permalink / raw)
  To: mp; +Cc: zsh-workers

> Here is a very small patch to fix expand-or-complete-prefix when in automenu
> mode (prob also in menucomplete mode too).
> 
> This comletion mechanism hasn't worked for a while, but I only just got around
> to fixing it.  No idea how to properly submit patches, so I'm just going to
> send to this mailing list with the hope that it's added.

This patch certainly fixes the bug you describe but it is not the proper
fix.  The real problem is that selfinsert() should not change menucomp and
addedsuffix (the later is necessary to make autoremoveslash usable with
expand-or-complete-prefix).  I posted patches for that about a year ago
which will be included in beta17.

Bye,

Zoltan



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~1996-05-01 21:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1996-05-01 17:22 expandorcompleteprefix patch Michael Pitman
1996-05-01 21:01 ` Zoltan Hidvegi

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).