zsh-2.6-beta17 : compiling on SCO - results

zsh-2.6-beta17 : compiling on SCO - results

[Peter Bray]

Note : Not list member (zsh-workers)

Greetings,

	I have grabbed beta17 and compiled it on

		SunOS 4.1.3_U1
		Solaris 2.4
		Solaris 2.5
		SCO 3.2v4.2 (Pentium/EISA/1 CPU)

	with ./configure --prefix=/opt/utils using gcc 2.7.2

	The Sun based platforms as expected compile without problem,
but as is usual SCO is another matter.

zsh configuration
-----------------
zsh version           : 2.6-beta17
host operating system : sco3.2v4.2
source code location  : .
compiler              : gcc
compiler flags        : -D__sco  -Wall -Wno-implicit -Wmissing-prototypes -O2
binary install path   : /opt/utils/bin
man page install path : /opt/utils/man
info install path     : /opt/utils/info

Unfortunately this gives the following when compiling

        gcc -c -I.. -I. -I.  -DHAVE_CONFIG_H -D__sco  -Wall -Wno-implicit -Wmissing-prototypes -O2 builtin.c
In file included from zsh.h:35,
                 from builtin.c:32:
system.h:114: redefinition of `struct timezone'
In file included from system.h:219,
                 from zsh.h:35,
                 from builtin.c:32:
/usr/include/sys/select.h:41: redefinition of `struct timeval'
builtin.c: In function `bin_kill':
builtin.c:663: warning: left-hand operand of comma expression has no effect
builtin.c: In function `bin_pwd':
builtin.c:872: warning: left-hand operand of comma expression has no effect
builtin.c: In function `bin_dirs':
builtin.c:897: warning: left-hand operand of comma expression has no effect
builtin.c: In function `cd_new_pwd':
builtin.c:1242: warning: left-hand operand of comma expression has no effect
builtin.c: In function `printdirstack':
builtin.c:1271: warning: left-hand operand of comma expression has no effect
builtin.c:1274: warning: left-hand operand of comma expression has no effect
builtin.c: In function `printcompctl':
builtin.c:2212: warning: left-hand operand of comma expression has no effect
builtin.c:2215: warning: left-hand operand of comma expression has no effect
builtin.c:2255: warning: left-hand operand of comma expression has no effect
builtin.c:2259: warning: left-hand operand of comma expression has no effect
builtin.c:2272: warning: left-hand operand of comma expression has no effect
builtin.c:2279: warning: left-hand operand of comma expression has no effect
builtin.c:2282: warning: left-hand operand of comma expression has no effect
builtin.c:2287: warning: left-hand operand of comma expression has no effect
builtin.c:2308: warning: left-hand operand of comma expression has no effect
builtin.c:2311: warning: left-hand operand of comma expression has no effect
builtin.c: In function `printqt':
builtin.c:2336: warning: left-hand operand of comma expression has no effect
builtin.c: In function `fclist':
builtin.c:2631: warning: left-hand operand of comma expression has no effect
builtin.c: In function `bin_times':
builtin.c:5222: warning: left-hand operand of comma expression has no effect
builtin.c:5224: warning: left-hand operand of comma expression has no effect
builtin.c:5226: warning: left-hand operand of comma expression has no effect
builtin.c:5228: warning: left-hand operand of comma expression has no effect
builtin.c: In function `printquoted':
builtin.c:5531: warning: left-hand operand of comma expression has no effect
builtin.c:5534: warning: left-hand operand of comma expression has no effect
builtin.c:5536: warning: left-hand operand of comma expression has no effect
builtin.c:5537: warning: left-hand operand of comma expression has no effect
builtin.c:5539: warning: left-hand operand of comma expression has no effect
builtin.c:5545: warning: left-hand operand of comma expression has no effect
builtin.c:5548: warning: left-hand operand of comma expression has no effect
builtin.c:5549: warning: left-hand operand of comma expression has no effect
builtin.c:5552: warning: left-hand operand of comma expression has no effect
builtin.c:5556: warning: left-hand operand of comma expression has no effect
builtin.c:5557: warning: left-hand operand of comma expression has no effect
builtin.c:5561: warning: left-hand operand of comma expression has no effect
*** Error code 1
 
Stop.
*** Error code 1
 
Stop.


Now am not going to say that I know the cause of the problems, but the 
fix which seemed to work for me is the following

In Src/Makefile change :

CFLAGS   = -D__sco  -Wall -Wno-implicit -Wmissing-prototypes -O2

to

CFLAGS   = -D__sco -O2

this seems to get rid of the 
 warning: left-hand operand of comma expression has no effect

and in Src/system.h to comment out the following sections :

/* PDB Modification for SCO
#ifdef __sco
struct timezone {
    short minutes;
};
#endif
*/

/* PDB Modification for SCO
#ifdef HAVE_SYS_SELECT_H
# include <sys/select.h>
#endif
*/

It would seem that sys/select.h redefines timeval and that timezone is
already defined. I think that some a little more fundamental may be wrong
(ie the configure on SCO) but I thought I share these experiences to
hopely leave someone who knows what they are doing to investiage the real
problems.

Remember this is SCO 3.2v4.2

Regards,
Peter
------------------------------------------------------------------------------
Peter Bray: Intelligent Network Development           Phone : (02) 395 3958
            Network Technology Group - Telstra        Fax   : (02) 395 3225
Street    : Lvl 9, Telecom Plaza, 320 Pitt St, Sydney Email : 
Mail      : Locked Bag 6581, GPO Sydney, NSW, 1100     pbray@ind.tansu.com.au
------------------------------------------------------------------------------

Re: zsh-2.6-beta17 : compiling on SCO - results

[Jos Backus]

    Hi,

In message <199605150215.MAA11431@cod.ind.tansu.com.au> Peter Bray wrote:
>and in Src/system.h to comment out the following sections :
>
>/* PDB Modification for SCO
>#ifdef __sco
>struct timezone {
>    short minutes;
>};
>#endif
>*/

I remember putting something like this in because struct timezone was missing
from the include files I had access to at that time, way back. It seems to be
there now.

>It would seem that sys/select.h redefines timeval and that timezone is
>already defined. I think that some a little more fundamental may be wrong
>(ie the configure on SCO)

How about SCO's include files instead? ;)


Groetjes,
Jos
--
Jos Backus           _/  _/_/_/                                 R-IS/SNB
                    _/  _/   _/                       Oce-Nederland B.V.
                   _/  _/_/_/                     Venlo, The Netherlands
             _/   _/  _/    _/
jos@oce.nl    _/_/   _/_/_/                  #include <std/disclaimer.h>

Re: zsh-2.6-beta17 : compiling on SCO - results

[Zoltan Hidvegi]

[-- Attachment #1: Type: application/pgp, Size: 9250 bytes --]

Re: zsh-2.6-beta17 : compiling on SCO - results

[Wayne Davison]

Peter Bray writes:
> host operating system : sco3.2v4.2

Here's the patches I used to apply to zsh when I compiled it for
this version of sco.  The first change allows zsh to accept tty
changes via things like stty.  It does have the effect of allowing
all program to change the tty settings (even the background ones),
but that's the best SCO can do since they have a bug in their
library.  SCO 5 doesn't have this problem, so it would have to
be made conditional for only older versions of SCO, and I never
figured out how best to conditionalize this (because we got rid
of SCO from my machine).

The line numbers will be a little off, since this patch was
last applied to beta 14.

Index: jobs.c
@@ -133,6 +133,10 @@
     }
 
     pgrp = gettygrp();           /* get process group of tty      */
+#ifdef __sco
+    if (pgrp == mypgrp)
+	pgrp = jn->gleader;
+#endif
 
     /* is this job in the foreground of an interactive shell? */
     if ((jn->gleader == pgrp || (pgrp > 1 && kill(-pgrp, 0) == -1)) &&
Index: system.h
@@ -110,7 +110,7 @@
  * that doesn't have gettimeofday.  Of course we *
  * probably will move to the POSIX time function *
  *  anyway.                                      */
-#ifdef __sco
+#ifdef __old_sco
 struct timezone {
     short minutes;
 };
@@ -119,7 +119,7 @@
 /* Sco needs the following include for struct utimbuf *
  * which is strange considering we do not use that    *
  * anywhere in the code                               */
-#ifdef __sco
+#ifdef __old_sco
 # include <utime.h>
 #endif
 
@@ -215,7 +215,7 @@
 # define WSTOPSIG(X) (((X)>>8)&0377)
 #endif
 
-#ifdef HAVE_SYS_SELECT_H
+#if defined(HAVE_SYS_SELECT_H) && !defined(__sco)
 # include <sys/select.h>
 #endif
 

..wayne..

RE: zsh-2.6-beta17 : compiling on SCO - results

[Joachim Reith]

Hello,

I have the same problem described by Peter, but
on sco3.2v5.0.2 (newer version).

./configure gives me

zsh configuration
-----------------
zsh version           : 2.6-beta17
host operating system : sco3.2v5.0.2
source code location  : .
compiler              : gcc
compiler flags        : -D__sco  -Wall -Wno-implicit -Wmissing-prototypes -O2
binary install path   : /usr/local/bin
man page install path : /usr/local/man
info install path     : /usr/local/info

the compilation runs until:

        gcc -c -I.. -I. -I.  -DHAVE_CONFIG_H -D__sco  -Wall -Wno-implicit -Wmiss
ing-prototypes -O2 builtin.c
In file included from zsh.h:35,
                 from builtin.c:32:
system.h:114: redefinition of `struct timezone'
*** Error code 1 (bu21)

If I comment out the struct timezone in system.h
(same as Peter):

tedesco@Src> diff system.h system.h-
113c113
< /* #ifdef __sco
---
> #ifdef __sco
117c117
< #endif */
---
> #endif


the compilation runs without any error.


P.S.: gcc --version  2.7-95q4
I don't have problems with 
CFLAGS   = -D__sco  -Wall -Wno-implicit -Wmissing-prototypes -O2



|>		SCO 3.2v4.2 (Pentium/EISA/1 CPU)
|>
|>	with ./configure --prefix=/opt/utils using gcc 2.7.2
|>
|>	The Sun based platforms as expected compile without problem,
|>but as is usual SCO is another matter.
|>
|>zsh configuration
|>-----------------
|>zsh version           : 2.6-beta17
|>host operating system : sco3.2v4.2
|>source code location  : .
|>compiler              : gcc
|>compiler flags        : -D__sco  -Wall -Wno-implicit -Wmissing-prototypes -O2
|>binary install path   : /opt/utils/bin
|>man page install path : /opt/utils/man
|>info install path     : /opt/utils/info
|>
|>Unfortunately this gives the following when compiling
|>
|>        gcc -c -I.. -I. -I.  -DHAVE_CONFIG_H -D__sco  -Wall -Wno-implicit -Wmissing-prototypes -O2 
builtin.c
|>In file included from zsh.h:35,
|>                 from builtin.c:32:
|>system.h:114: redefinition of `struct timezone'
|>
|> ... stuff deleted