vi-goto-column

vi-goto-column

[Peter Stephenson]

The behaviour of vi-goto-column has changed: it now won't go to the
last column, i.e. the space after all the characters.  This was
presumably introduced by some mistaken analogy with vi, where there is
no space at the end of the line after the last inserted character.  In
zsh there is (remember, ^[| can be called from emacs mode) and there
is no reason why the shell shouldn't go to it.  The change has already
caused problems here.  The excuse `we randomly changed this because we
thought it would be nice if it did something else' is not widely
accepted (to put it mildly) by users and system managers.

% ~
   ^ typing ^[2^[| here goes to the first character instead of staying put.

-- 
Peter Stephenson <pws@ifh.de>       Tel: +49 33762 77366
WWW:  http://www.ifh.de/~pws/       Fax: +49 33762 77413
Deutsches Elektronen-Synchrotron --- Institut fuer Hochenergiephysik Zeuthen
DESY-IfH, 15735 Zeuthen, Germany.

Re: vi-goto-column

[Zoltan Hidvegi]

Peter Stephenson wrote:
> The behaviour of vi-goto-column has changed: it now won't go to the
> last column, i.e. the space after all the characters.  This was
> presumably introduced by some mistaken analogy with vi, where there is
> no space at the end of the line after the last inserted character.  In

In vi you cannot put the cursor after the last character and it does not
matter wether it is a space or not.  Zsh just does the same.

The patch below will probably does what you want but vi fans may oppose
this patch.  POSIX.2 upe specifies the requirements for vi mode, but
unfortunately I do not have this document so I do not know how this should
behave.  Bash behaves like zsh so I think the current behaviour
(ie. without the patch below) is correct.

Zoltan


*** Src/Zle/zle_move.c	1997/01/12 00:46:43	3.1.1.5
--- Src/Zle/zle_move.c	1997/01/14 13:46:03
***************
*** 181,188 ****
  	cs = x + zmult;
      else
  	cs = y + zmult;
!     if (cs >= y)
! 	cs = y - 1;
      if (cs < x)
  	cs = x;
  }
--- 181,188 ----
  	cs = x + zmult;
      else
  	cs = y + zmult;
!     if (cs > y)
! 	cs = y;
      if (cs < x)
  	cs = x;
  }

Re: vi-goto-column

[Zefram]

Zoltan Hidvegi wrote:
>The patch below will probably does what you want but vi fans may oppose
>this patch.  POSIX.2 upe specifies the requirements for vi mode, but
>unfortunately I do not have this document so I do not know how this should
>behave.  Bash behaves like zsh so I think the current behaviour
>(ie. without the patch below) is correct.

This patch is correct.  After any command has been executed, ZLE will
move the cursor back one column if it is at the very end of a line in
vi command mode, so for vi users the visible behaviour is not changed
by this patch.

-zefram

Re: vi-goto-column

[Peter Stephenson]

Zefram wrote:
> This patch is correct.  After any command has been executed, ZLE will
> move the cursor back one column if it is at the very end of a line in
> vi command mode, so for vi users the visible behaviour is not changed
> by this patch.

Thanks, this is exactly what I was hoping for.  I hope this can go in
whether it happens to agree with bash in emacs mode or not --- most of the
comments about zsh (which is widely used here) I get are about little
things like this which have changed between versions but which can still
be a big annoyance.  (The institute is just switching from 2.5 to 3.0,
so don't be surprised if there are more.)

-- 
Peter Stephenson <pws@ifh.de>       Tel: +49 33762 77366
WWW:  http://www.ifh.de/~pws/       Fax: +49 33762 77413
Deutsches Elektronen-Synchrotron --- Institut fuer Hochenergiephysik Zeuthen
DESY-IfH, 15735 Zeuthen, Germany.