Multibyte test regressed on MacOSX Leopard

Multibyte test regressed on MacOSX Leopard

[İsmail Dönmez]

Hi,

With the latest changes, multibyte test now fails on MacOSX 10.5.5 Leopard,

./D07multibyte.ztst: starting.
Testing multibyte with locale en_US.UTF-8
Test ./D07multibyte.ztst failed: bad status 1, expected 0 from:
 mkdir glob
 mkdir glob/'()Ą' glob/'()Ā'
 mkdir glob/'()Ą'/foo glob/'()Ā'/bar
 tmp1=('glob/\(\)Ą/*')
 print $~tmp1
 tmp1=('glob/\(\)Ā/*')
 print $~tmp1
Error output:
(eval):5: no matches found: glob/\(\)Ą/*
Was testing: Backslashes and metafied characters in patterns
./D07multibyte.ztst: test failed.

Regards,
ismail

Re: Multibyte test regressed on MacOSX Leopard

[Peter Stephenson]

..On Wed, 15 Oct 2008 21:55:56 +0300
"İsmail Dönmez" <ismail@namtrac.org> wrote:
> With the latest changes, multibyte test now fails on MacOSX 10.5.5 Leopard,
> 
> ./D07multibyte.ztst: starting.
> Testing multibyte with locale en_US.UTF-8
> Test ./D07multibyte.ztst failed: bad status 1, expected 0 from:
>  mkdir glob
>  mkdir glob/'()Ą' glob/'()Ā'
>  mkdir glob/'()Ą'/foo glob/'()Ā'/bar
>  tmp1=('glob/\(\)Ą/*')
>  print $~tmp1
>  tmp1=('glob/\(\)Ā/*')
>  print $~tmp1
> Error output:
> (eval):5: no matches found: glob/\(\)Ą/*
> Was testing: Backslashes and metafied characters in patterns
> ./D07multibyte.ztst: test failed.

I wonder if this is because the characters are stored in a different
format in file names.

Index: Test/D07multibyte.ztst
===================================================================
RCS file: /cvsroot/zsh/zsh/Test/D07multibyte.ztst,v
retrieving revision 1.26
diff -u -r1.26 D07multibyte.ztst
--- Test/D07multibyte.ztst	11 Oct 2008 22:16:01 -0000	1.26
+++ Test/D07multibyte.ztst	18 Oct 2008 15:12:56 -0000
@@ -396,13 +396,10 @@
 >OK
 >OK
 
-  mkdir glob
-  mkdir glob/'()Ą' glob/'()Ā'
-  mkdir glob/'()Ą'/foo glob/'()Ā'/bar
-  tmp1=('glob/\(\)Ą/*')
-  print $~tmp1
-  tmp1=('glob/\(\)Ā/*')
-  print $~tmp1
+  tmp1='glob/\(\)Ą/*'
+  [[ glob/'()Ą'/foo == $~tmp1 ]] && print "Matched against $tmp1"
+  tmp1='glob/\(\)Ā/*'
+  [[ glob/'()Ā'/bar == $~tmp1 ]] && print "Matched against $tmp1"
 0:Backslashes and metafied characters in patterns
->glob/()Ą/foo
->glob/()Ā/bar
+>Matched against glob/()Ą/*
+>Matched against glob/()Ā/*


-- 
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/

Re: Multibyte test regressed on MacOSX Leopard

[İsmail Dönmez]

On Sat, Oct 18, 2008 at 18:13, Peter Stephenson
<p.w.stephenson@ntlworld.com> wrote:
> ..On Wed, 15 Oct 2008 21:55:56 +0300
> "İsmail Dönmez" <ismail@namtrac.org> wrote:
>> With the latest changes, multibyte test now fails on MacOSX 10.5.5 Leopard,
>>
>> ./D07multibyte.ztst: starting.
>> Testing multibyte with locale en_US.UTF-8
>> Test ./D07multibyte.ztst failed: bad status 1, expected 0 from:
>>  mkdir glob
>>  mkdir glob/'()Ą' glob/'()Ā'
>>  mkdir glob/'()Ą'/foo glob/'()Ā'/bar
>>  tmp1=('glob/\(\)Ą/*')
>>  print $~tmp1
>>  tmp1=('glob/\(\)Ā/*')
>>  print $~tmp1
>> Error output:
>> (eval):5: no matches found: glob/\(\)Ą/*
>> Was testing: Backslashes and metafied characters in patterns
>> ./D07multibyte.ztst: test failed.
>
> I wonder if this is because the characters are stored in a different
> format in file names.
>
> Index: Test/D07multibyte.ztst
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Test/D07multibyte.ztst,v
> retrieving revision 1.26
> diff -u -r1.26 D07multibyte.ztst
> --- Test/D07multibyte.ztst      11 Oct 2008 22:16:01 -0000      1.26
> +++ Test/D07multibyte.ztst      18 Oct 2008 15:12:56 -0000
> @@ -396,13 +396,10 @@
>  >OK
>  >OK
>
> -  mkdir glob
> -  mkdir glob/'()Ą' glob/'()Ā'
> -  mkdir glob/'()Ą'/foo glob/'()Ā'/bar
> -  tmp1=('glob/\(\)Ą/*')
> -  print $~tmp1
> -  tmp1=('glob/\(\)Ā/*')
> -  print $~tmp1
> +  tmp1='glob/\(\)Ą/*'
> +  [[ glob/'()Ą'/foo == $~tmp1 ]] && print "Matched against $tmp1"
> +  tmp1='glob/\(\)Ā/*'
> +  [[ glob/'()Ā'/bar == $~tmp1 ]] && print "Matched against $tmp1"
>  0:Backslashes and metafied characters in patterns
> ->glob/()Ą/foo
> ->glob/()Ā/bar
> +>Matched against glob/()Ą/*
> +>Matched against glob/()Ā/*

This fixed the problem for me.

Thanks!

/ismail