Re: seg fault fixed and Makefile change

Re: seg fault fixed and Makefile change

[Sven Wischnowsky]

Oliver Kiddle wrote:

> Sven Wischnowsky wrote:
> > 
> > I couldn't reproduce this (neither before nor after this patch -- your
> > match specs would have helped), but this looks suspiciously similar to
> > the one above... could you try with this patch?
> 
> That's fixed it: it now works fine, thanks.

Uff ;-)

> ...
> 
> Completion for netscape remote commands doesn't seem to work properly
> anymore:
> netscape -remote <tab>
> Basically, it is a bit too eager to put the \( suffix in. This did
> actually work before but I've always felt that this part of _netscape
> (which I am to blame for) is a bit of a nasty hack. Basically, the
> '(' suffix needs to be quoted unless it already is and that was the
> way I found which worked. 

Hm. What exactly doesn't seem to work properly for you anymore? The
only ugliness I can see is that you get the `\(' if the string is not
in quotes but when it is. Why not use:

  compadd -s '(' -S '' - ...

or

  local suf='('
  compquote suf
  compadd -qS "$s" - ...

and if the `compset -q' is really needed, put it after the compquote.

I don't really know all the things that are possible with -remote,
though, so these suggestions may not be usable(?).

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

_netscape

[Oliver Kiddle]

Sven Wischnowsky wrote:

> Hm. What exactly doesn't seem to work properly for you anymore? The
> only ugliness I can see is that you get the `\(' if the string is not
> in quotes but when it is. 

I've tried some of the things you suggest and I can't get it to work although I
have managed to get the same behaviour as now with a more succinct _netscape.

The only thing which is particularly special about netscape remote commands is
that they contain brackets so these brackets need to be quoted. 

If I manually use a single or double quote around the whole remote command,
things work fine:

netscape -remote 'open<tab> lists openFile and openURL
netscape -remote 'openU<tab> completes openURL(, the bracket being a suffix
netscape -remote 'openURL(<tab> is now completing urls

Where things go wrong is when I don't use a quote:

netscape -remote open<tab> completes '\(', subsequent tabs insert more, I would
    expect to see openFile and openURL listed
netscape -remote openU<tab> works - completes to openURL\(
netscape -remote openURL\(<tab> also works - it completes URLs.

The first of these is where it isn't workling. The thing which is missing is that I never get the list of matches, just the inserted brackets.

Oliver Kiddle

seg fault fixed and Makefile change

[Oliver Kiddle]

Sven Wischnowsky wrote:
> 
> I couldn't reproduce this (neither before nor after this patch -- your
> match specs would have helped), but this looks suspiciously similar to
> the one above... could you try with this patch?

That's fixed it: it now works fine, thanks.

This small patch to the Makefile causes it to install the functions
before the man pages. This is because the man page installation fails
if yodl isn't installed meaning that I have to do a separate
make install.fns. Of course this is only an issue if someone compiles
from CVS because the proper releases include pre-built man pages.

Completion for netscape remote commands doesn't seem to work properly
anymore:
netscape -remote <tab>
Basically, it is a bit too eager to put the \( suffix in. This did
actually work before but I've always felt that this part of _netscape
(which I am to blame for) is a bit of a nasty hack. Basically, the
'(' suffix needs to be quoted unless it already is and that was the
way I found which worked. 

Oliver

Index: Makefile.in
===================================================================
RCS file: /cvsroot/zsh/zsh/Makefile.in,v
retrieving revision 1.3
diff -u -r1.3 Makefile.in
--- Makefile.in 2000/04/06 11:47:46     1.3
+++ Makefile.in 2000/05/15 11:57:53
@@ -60,8 +60,8 @@
        $(MAKE) install STRIPFLAGS="-s"

 # install/uninstall most things
-install: install.bin install.modules install.man install.fns
-uninstall: uninstall.bin uninstall.modules uninstall.man uninstall.fns
+install: install.bin install.modules install.fns install.man
+uninstall: uninstall.bin uninstall.modules uninstall.fns uninstall.man

 # install/uninstall just the binary
 install.bin uninstall.bin: