completion bug: chmod +rX

completion bug: chmod +rX

[Ignacy Gawedzki]

Hi,

I tried to dive into completion code, but must admit that it requires far more
time to comprehend than I initially supposed.  So I would like to report a
problem that's quite annoying sometimes: "chmod a+rX" doesn't complete
properly (it doesn't offer _any_ file).  From what I managed to see, it has
something to do with the way _files or maybe _path_files works.

Has anyone any idea or suggestion?

-- 
Everything is more fun naked except cooking with grease.

Re: completion bug: chmod +rX

[Stephen Rueger]

On Thu, Oct 06, 2005 at 11:29:02PM +0200, Ignacy Gawedzki wrote:

> Has anyone any idea or suggestion?

This patch should do.

--- Completion/Unix/Command/_chmod.old	2005-10-07 00:46:41.000000000 +0200
+++ Completion/Unix/Command/_chmod	2005-10-07 00:49:34.000000000 +0200
@@ -67,7 +67,7 @@
       local spec who op priv
       local -a specs
       for spec in ${(s:,:)words[2]}; do
-	if [[ ${spec#*[+-=]} != [rwxst]* ]]; then
+	if [[ ${spec#*[+-=]} != [rwxst]## ]]; then
 	  _files && ret=0
 	  return ret
 	fi


-- 
Stephen Rüger
stephen.rueger@rechnerpost.org

Re: completion bug: chmod a+rX

[Ignacy Gawedzki]

On Fri, Oct 07, 2005 at 01:07:55AM +0200, thus spake Stephen Rueger:
> On Thu, Oct 06, 2005 at 11:29:02PM +0200, Ignacy Gawedzki wrote:
> 
> > Has anyone any idea or suggestion?
> 
> This patch should do.

It does, thank you very much. =)

-- 
Information wants to be beer, or something like that.