From: Wayne Davison <wayned@users.sourceforge.net>
To: zsh-workers@sunsite.dk
Subject: Re: bug in completion/expansion of files with LANG=C
Date: Sat, 7 Jan 2006 14:44:47 -0800 [thread overview]
Message-ID: <20060107224447.GA30232@dot.blorf.net> (raw)
In-Reply-To: <20060106215829.GG10111@dot.blorf.net>
[-- Attachment #1: Type: text/plain, Size: 521 bytes --]
Here's a patch to fix the first part of having non-convertable
characters found when completing filenames: we now output the full
filename string instead of a truncated version of it. I chose to just
call nicechar() to have it output a \M-x sequence (to make it the same
as the non-multibyte code).
However, I was wondering if it would be nicer to switch both the old and
the new code over to using a 3-digit octal value in such output? E.g.
output "\303" instead of "\M-C", and "\201" instead of "\M-^A"?
..wayne..
[-- Attachment #2: mb_niceformat.patch --]
[-- Type: text/plain, Size: 931 bytes --]
--- Src/utils.c 15 Dec 2005 14:51:41 -0000 1.108
+++ Src/utils.c 7 Jan 2006 22:36:34 -0000
@@ -3475,22 +3475,21 @@ mb_niceformat(const char *s, FILE *strea
if (ret == (size_t)-1 || ret == (size_t)-2)
{
+ /* The byte didn't convert, so output it as a \M-x sequence. */
+ fmt = nicechar(*(unsigned char*)ptr);
+ ret = newl = 1;
+ } else {
/*
- * We're a bit stuck here. I suppose we could
- * just stick with \M-... for the individual bytes.
+ * careful in case converting NULL returned 0: NULLs are
+ * real characters for us.
*/
- break;
+ if (c == L'\0' && ret == 0)
+ ret = 1;
+ fmt = wcs_nicechar(c, &newl, NULL);
}
- /*
- * careful in case converting NULL returned 0: NULLs are real
- * characters for us.
- */
- if (c == L'\0' && ret == 0)
- ret = 1;
+
umlen -= ret;
ptr += ret;
-
- fmt = wcs_nicechar(c, &newl, NULL);
l += newl;
if (stream)
next prev parent reply other threads:[~2006-01-07 22:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-06 21:58 Wayne Davison
2006-01-06 22:40 ` Peter Stephenson
2006-01-07 0:59 ` Wayne Davison
2006-01-07 0:17 ` Wayne Davison
2006-01-07 22:44 ` Wayne Davison [this message]
2006-01-08 5:56 ` Bart Schaefer
2006-01-08 8:06 ` Wayne Davison
2006-01-08 18:03 ` Peter Stephenson
2006-01-08 23:16 ` Wayne Davison
2006-01-12 1:26 ` Wayne Davison
2006-01-09 1:42 ` Wayne Davison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060107224447.GA30232@dot.blorf.net \
--to=wayned@users.sourceforge.net \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).