From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@sunsite.dk
Subject: Re: bug in completion/expansion of files with LANG=C
Date: Sun, 8 Jan 2006 18:03:09 +0000 [thread overview]
Message-ID: <20060108180309.01082ac4.p.w.stephenson@ntlworld.com> (raw)
In-Reply-To: <20060108080621.GA32692@dot.blorf.net>
On Sun, 8 Jan 2006 00:06:21 -0800
Wayne Davison <wayned@users.sourceforge.net> wrote:
> As for my patch in the grandparent email, I noticed some problems with
> it: the manpage for mbrtowc() says that the state of the mbstate_t
> object is undefined after the function returns -1, so the code should
> reset it to a known state. When the function returns -2, it means the
> code scanned to the end of the string without finding the end of a wide
> character, so perhaps we should treat all the remaining characters as
> invalid?
You mean output everything remaining in the string as special codes
rather than real (multibyte) characters? Yes, that would make sense.
> 1. It looks to me like the code in wcs_nicechar() that calls
> wcswidth(&c, 1) could really just call wcwidth(c), right? If not,
> what am I missing?
Yes, and it's the only occurrence of wcswidth(), so it would make sense
to remove it. This would make my patch for probing for wcswidth()
redundant.
> 2. The code in mb_niceformat() calls strlen() on the "fmt" string
> returned by wcs_nicechar(), but it seems to me that it could just use
> the width that wcs_nicechar() returned, right?
I think it really needs the length of the string here. The width
produced by wcs_nicechar() is a printing width, which isn't the same.
--
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page still at http://www.pwstephenson.fsnet.co.uk/
next prev parent reply other threads:[~2006-01-08 18:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-06 21:58 Wayne Davison
2006-01-06 22:40 ` Peter Stephenson
2006-01-07 0:59 ` Wayne Davison
2006-01-07 0:17 ` Wayne Davison
2006-01-07 22:44 ` Wayne Davison
2006-01-08 5:56 ` Bart Schaefer
2006-01-08 8:06 ` Wayne Davison
2006-01-08 18:03 ` Peter Stephenson [this message]
2006-01-08 23:16 ` Wayne Davison
2006-01-12 1:26 ` Wayne Davison
2006-01-09 1:42 ` Wayne Davison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060108180309.01082ac4.p.w.stephenson@ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).