From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: PATCH: Re: Broken completion with UTF-8 description
Date: Thu, 21 Sep 2006 18:22:24 +0100 [thread overview]
Message-ID: <200609211722.k8LHMOQ5008776@news01.csr.com> (raw)
In-Reply-To: <200609212104.23198.arvidjaar@newmail.ru>
Andrey Borzenkov wrote:
> How are matches sorted currently? Do we have another function doing collate
> sort or completion simply sorts in numerical order? I am not sure if using
> strpcmp is the right thing but this is the first I caught.
Did you take a look at strbpcmp() in zle_tricky.c?
> Please review as I am not sure is usage of ztrdup/zfree is right in this case
> .
It'll work, but the standard completion system trick seems to be to
dupstring() and not worry about the temporary usage.
You'll appreciate that it's not that easy to understand the completion
code simply by looking at it, but I didn't see anything that looked
obviously stupid.
> +/*
> + * FIXME this should be defined globally. I have to find other places
> + * where it is used
> + * */
> +
> +#define INTERMATCH_GAP 2
Ah, I see you've found another undocumented magic number used without
any indication. I found a few of those.
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
To access the latest news from CSR copy this link into a web browser: http://www.csr.com/email_sig.php
next prev parent reply other threads:[~2006-09-21 17:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-17 14:53 Andrey Borzenkov
2006-09-17 19:16 ` Peter Stephenson
2006-09-21 17:04 ` PATCH: " Andrey Borzenkov
2006-09-21 17:22 ` Peter Stephenson [this message]
2006-09-21 17:44 ` Andrey Borzenkov
2006-10-07 7:58 ` Andrey Borzenkov
2006-09-21 20:02 ` Peter Stephenson
2006-09-23 7:05 ` Andrey Borzenkov
2006-09-23 7:36 ` Andrey Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609211722.k8LHMOQ5008776@news01.csr.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).