From: Peter Stephenson <pws@csr.com>
To: Zsh Hackers <zsh-workers@sunsite.dk>
Subject: Re: Bug: Wrong completion of $(( $(!cmd
Date: Tue, 23 Jan 2007 13:10:32 +0000 [thread overview]
Message-ID: <20070123131032.34ee48e9.pws@csr.com> (raw)
In-Reply-To: <200701231304.l0ND4b3t011195@news01.csr.com>
Peter Stephenson <pws@csr.com> wrote:
> Geoff Wing wrote:
> > On Saturday 2007-01-06 23:48 +1100, J_rg Sommer output:
> > :% echo 12
> > :12
> > :% echo $(( $(!echo<TAB>
> > :% echo $($(( $(echo 12
> >
> > and inungetc() just after gives me 11 lines of
> > Warning: backing up wrong character.
>
> The problem is somewhere here (in lex.c). If dquote_parse() returns
> non-zero it's an error indication, not a character, so the hungetc(c) is
> definitely wrong in that case. However, I don't understand the
> intention behind error handling at this point. I think we probably need
> to return 1 earlier.
Is it this simple? Seems to do the trick...
Index: Src/lex.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/lex.c,v
retrieving revision 1.37
diff -u -r1.37 lex.c
--- Src/lex.c 19 Jan 2007 21:36:03 -0000 1.37
+++ Src/lex.c 23 Jan 2007 13:08:47 -0000
@@ -542,14 +542,14 @@
c = dquote_parse(')', 0);
cmdpop();
*bptr = '\0';
- if (!c) {
- c = hgetc();
- if (c == ')')
- return 1;
- hungetc(c);
- lexstop = 0;
- c = ')';
- }
+ if (c)
+ return 1;
+ c = hgetc();
+ if (c == ')')
+ return 1;
+ hungetc(c);
+ lexstop = 0;
+ c = ')';
hungetc(c);
lexstop = 0;
while (len > oldlen) {
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
To access the latest news from CSR copy this link into a web browser: http://www.csr.com/email_sig.php
To get further information regarding CSR, please visit our Investor Relations page at http://ir.csr.com/csr/about/overview
next prev parent reply other threads:[~2007-01-23 13:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-06 2:35 Jörg Sommer
2007-01-22 23:43 ` Geoff Wing
2007-01-23 13:04 ` Peter Stephenson
2007-01-23 13:10 ` Peter Stephenson [this message]
2007-01-23 15:23 ` Bart Schaefer
2007-01-23 15:35 ` Peter Stephenson
2007-01-23 15:47 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070123131032.34ee48e9.pws@csr.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).