From: Peter Stephenson <pws@csr.com>
To: Zsh Hackers <zsh-workers@sunsite.dk>
Subject: Re: Bug: Wrong completion of $(( $(!cmd
Date: Tue, 23 Jan 2007 15:35:28 +0000 [thread overview]
Message-ID: <200701231535.l0NFZSwY020854@news01.csr.com> (raw)
In-Reply-To: <070123072344.ZM12121@torch.brasslantern.com>
Bart Schaefer wrote:
> On Jan 23, 1:04pm, Peter Stephenson wrote:
> }
> } The problem is somewhere here (in lex.c). If dquote_parse() returns
> } non-zero it's an error indication, not a character, so the hungetc(c)
> } is definitely wrong in that case.
>
> I don't think that's true.
I presume you mean the second statement. If you've got any evidence
against the first statement I'd like to see it.
> If you look at the tail end of dquote_parse()
> you'll see that if lexstop is false the return value of dquote_parse() is
> overloaded -- it's both an error indication AND the most recently read
> character from the input stream. That's what hungetc() is trying to put
> back in that spot in cmd_or_math().
>
> That doesn't make it correct, but that's what's going on. There must be
> (or have been at some past time) some other reason higher up the parse
> tree why that final character needed to be retained.
I looked a bit further and it seems it's used in gettokstr() to
hungetc() a character when we have an error. I don't understand what
that buys when we can't parse the input anyway, particularly since we
don't even know if it's a valid character because of the other way of
setting the value; could it have been a hack to get history lines to be
stored properly after an error? I recall we improved that at some
point, so this hack may not be necessary.
I traced it (the "err = c" thing in dquote_parse()) back in the code to
3.0.0, which is before the use in cmd_or_math() that is causing the
problem, so it wasn't introduced specifically for that, and
cmd_or_math() was roughly the way it now is right back in 3.0.8.
Consequently (although what you say is true) I don't see anything wrong
with the proposed change.
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
To access the latest news from CSR copy this link into a web browser: http://www.csr.com/email_sig.php
To get further information regarding CSR, please visit our Investor Relations page at http://ir.csr.com/csr/about/overview
next prev parent reply other threads:[~2007-01-23 15:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-06 2:35 Jörg Sommer
2007-01-22 23:43 ` Geoff Wing
2007-01-23 13:04 ` Peter Stephenson
2007-01-23 13:10 ` Peter Stephenson
2007-01-23 15:23 ` Bart Schaefer
2007-01-23 15:35 ` Peter Stephenson [this message]
2007-01-23 15:47 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701231535.l0NFZSwY020854@news01.csr.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).