BUG: "setopt autocd" and auto-cd completion of dirs with funny (Unicode) chars

BUG: "setopt autocd" and auto-cd completion of dirs with funny (Unicode) chars

[Fernando Vezzosi]

[-- Attachment #1: Type: text/plain, Size: 968 bytes --]

Hi -workers,
zsh-beta 4.3.2-dev-1+20070413-1 on Debian Sid (i686-pc-linux-gnu) here..

I use zsh-beta because the plain zsh package doesn't complete
Unicode (UTF-8) filenames and dirs.  With zsh-beta it's much better, but
it fails when auto-cd`ing into some Unicode-named directory..  Example
follows:

% ls -F
♠♣♥♦/ some_dir/ another_dir/
% setopt autocd
% cd ♠♣♥♦
% pwd
/home/buccia/♠♣♥♦
% cd ../
% ./<TAB>
(Completes all directories without Unicode names)
% ./♠♣<TAB>
(Doesn't complete anything)
% cd ./♠♣<TAB> # I insert "cd" in front of it
% cd ./♠♣♥♦ # correctly completed

Locale is en_US.UTF-8
Menu completion works fine, but I tend not to use it..
autocd completion of directories without funny wchars works normally.

If you need any other details, please let me know!

Bye, and keep up the good work!

-- 
  Fernando Vezzosi
	       3F29 4D20 510E E1AE 991D  3B12 D6BE 7C05 B289 97C9

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: BUG: "setopt autocd" and auto-cd completion of dirs with funny (Unicode) chars

[Peter Stephenson]

Fernando Vezzosi <fvezzosi@masobit.net> wrote:
> Hi -workers,
> zsh-beta 4.3.2-dev-1+20070413-1 on Debian Sid (i686-pc-linux-gnu)
> here..
> 
> I use zsh-beta because the plain zsh package doesn't complete
> Unicode (UTF-8) filenames and dirs.  With zsh-beta it's much better,
> but it fails when auto-cd`ing into some Unicode-named directory..

Aha... you're using raw out-of-the-box completion, not compinit, right?

Index: Src/Zle/compctl.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/compctl.c,v
retrieving revision 1.31
diff -u -r1.31 compctl.c
--- Src/Zle/compctl.c	3 Dec 2006 21:07:18 -0000	1.31
+++ Src/Zle/compctl.c	27 Apr 2007 16:00:44 -0000
@@ -2188,9 +2188,14 @@
 		if (!test)
 		    continue;
 		if (!all) {
+		    char *ums;
+		    int umlen;
 		    /* We still have to check the file type, so
prepare *
 		     * the path buffer by appending the
filename.       */
-		    strcpy(q, n);
+		    ums = dupstring(n);
+		    unmetafy(ums, &umlen);
+		    memcpy(q, ums, umlen);
+		    q[umlen] = '\0';
 		    /* And do the stat. */
 		    if (stat(p, &buf) < 0)
 			continue;

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


To access the latest news from CSR copy this link into a web browser:  http://www.csr.com/email_sig.php

To get further information regarding CSR, please visit our Investor Relations page at http://ir.csr.com/csr/about/overview

Re: BUG: "setopt autocd" and auto-cd completion of dirs with funny (Unicode) chars

[Fernando Vezzosi]

[-- Attachment #1: Type: text/plain, Size: 731 bytes --]

Hi! Thanks for the quick response & patch :)  Works perfectly, from what
i can see.

On Fri, Apr 27, 2007 at 05:01:45PM +0100, Peter Stephenson wrote:
> Fernando Vezzosi <fvezzosi@masobit.net> wrote:
> > Hi -workers,
> > zsh-beta 4.3.2-dev-1+20070413-1 on Debian Sid (i686-pc-linux-gnu)
> > here..
> > 
> > I use zsh-beta because the plain zsh package doesn't complete
> > Unicode (UTF-8) filenames and dirs.  With zsh-beta it's much better,
> > but it fails when auto-cd`ing into some Unicode-named directory..
> 
> Aha... you're using raw out-of-the-box completion, not compinit, right?

Right!

Bye, and happy zsh`ing ;)


-- 
  Fernando Vezzosi
	       3F29 4D20 510E E1AE 991D  3B12 D6BE 7C05 B289 97C9

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]