Bug report: count undeclared in utils.c

Bug report: count undeclared in utils.c

[Lasse Kliemann]

[-- Attachment #1: Type: text/plain, Size: 644 bytes --]

Compiling zsh 4.3.4 on OpenBSD, I get:

utils.c: In function `getkeystring':
utils.c:4746: error: `count' undeclared (first use in this function)
utils.c:4746: error: (Each undeclared identifier is reported only once
utils.c:4746: error: for each function it appears in.)

Having a look at the source utils.c, I suspect that `count' is really 
undeclared in case that 

- `HAVE_NL_LANGINFO' and `CODESET' are defined,
- and `HAVE_ICONV' is not defined,
- and one of the following is also not defined: `HAVE_WCHAR_H', 
  `HAVE_WCTOMB', `__STDC_ISO_10646__'.

Maybe this is a rare configuration that only occurs on OpenBSD.




[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: Bug report: count undeclared in utils.c

[Clint Adams]

> Compiling zsh 4.3.4 on OpenBSD, I get:
> 
> utils.c: In function `getkeystring':
> utils.c:4746: error: `count' undeclared (first use in this function)
> utils.c:4746: error: (Each undeclared identifier is reported only once
> utils.c:4746: error: for each function it appears in.)
> 
> Having a look at the source utils.c, I suspect that `count' is really 
> undeclared in case that 
> 
> - `HAVE_NL_LANGINFO' and `CODESET' are defined,
> - and `HAVE_ICONV' is not defined,
> - and one of the following is also not defined: `HAVE_WCHAR_H', 
>   `HAVE_WCTOMB', `__STDC_ISO_10646__'.
> 
> Maybe this is a rare configuration that only occurs on OpenBSD.

Builds and passes 'make check' for me on OpenBSD 3.5.  GNU iconv is in
/usr/local but I didn't tell configure to find it there.

config.h lines:

#define HAVE_NL_LANGINFO 1
/* #undef HAVE_ICONV */
/* #undef HAVE_WCHAR_H */
#define HAVE_WCTOMB 1


wchar_t and wctomb are defined in stdlib.h; there is no wchar.h.
__STDC_ISO_10646__ does not appear to be defined anywhere.

Re: Bug report: count undeclared in utils.c

[Phil Pennock]

[-- Attachment #1: Type: text/plain, Size: 644 bytes --]

On 2007-05-27 at 13:52 +0200, Lasse Kliemann wrote:
> Compiling zsh 4.3.4 on OpenBSD, I get:
[...]
> Having a look at the source utils.c, I suspect that `count' is really 
> undeclared in case that 
[...]
> Maybe this is a rare configuration that only occurs on OpenBSD.

Nope, I encountered it too, on FreeBSD.  CVS has the patch in.

  From: Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>
  Subject: 4.3.4 HEAD and iconv
  To: zsh-workers@sunsite.dk
  Date: Wed, 25 Apr 2007 18:17:02 -0700
  Message-ID: <20070426011702.GA86823@redoubt.spodhuis.org>
  X-Seq: 23326

http://www.zsh.org/mla/workers/2007/msg00247.html


[-- Attachment #2: Type: application/pgp-signature, Size: 155 bytes --]