From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@sunsite.dk, "Jörg Sommer" <joerg@alea.gnuu.de>,
426161-forwarded@bugs.debian.org
Subject: Re: Bug#426161: zsh: crashes in reverse_menu
Date: Mon, 28 May 2007 13:29:22 +0100 [thread overview]
Message-ID: <200705281229.l4SCTMuI003623@pwslaptop.csr.com> (raw)
In-Reply-To: Message from Clint Adams <schizo@debian.org> of "Sat, 26 May 2007 22:50:23 EDT." <20070527025023.GA19806@scowler.net>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
Clint Adams wrote:
> On Sat, May 26, 2007 at 10:54:26PM +0200, Jörg Sommer wrote:
> > Hi,
> >
> > after typing “vared CF” I've called “reverse-menu-complete” with M-x and
> > zsh crashes. This also happens in zsh-beta 4.3.4-dev-0+20070516-1 and is
> > not #416970.
>
> This is because reverse_menu() is trying to dereference minfo.group
> which is NULL.
I suspect that means we shouldn't do that.
Index: Src/Zle/compresult.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/compresult.c,v
retrieving revision 1.70
diff -u -r1.70 compresult.c
--- Src/Zle/compresult.c 30 Oct 2006 14:13:39 -0000 1.70
+++ Src/Zle/compresult.c 28 May 2007 12:29:55 -0000
@@ -1227,6 +1227,9 @@
{
int was_meta;
+ if (minfo.cur == NULL)
+ return 1;
+
do {
if (minfo.cur == (minfo.group)->matches) {
do {
--
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/
next prev parent reply other threads:[~2007-05-28 12:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070526205426.GA19686@alea.gnuu.de>
2007-05-27 2:50 ` Clint Adams
2007-05-28 12:29 ` Peter Stephenson [this message]
[not found] <20070825004026.12883.52907.reportbug@chain.digitalkingdom.org>
2007-08-25 14:51 ` Bug#439425: Random, but fairly regular, zsh segfaults Clint Adams
2007-08-25 17:50 ` Peter Stephenson
2007-08-25 17:54 ` Robin Lee Powell
2007-08-27 0:11 ` Clint Adams
2007-08-27 2:29 ` Robin Lee Powell
2007-08-25 17:53 ` Robin Lee Powell
[not found] <schizo@debian.org>
2007-04-14 20:53 ` release whinging Clint Adams
2007-04-15 18:58 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705281229.l4SCTMuI003623@pwslaptop.csr.com \
--to=p.w.stephenson@ntlworld.com \
--cc=426161-forwarded@bugs.debian.org \
--cc=joerg@alea.gnuu.de \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).