Re: the mv trap

Re: the mv trap

[zzapper]

Vincent Lefevre <vincent@vinc17.org> wrote in
news:20070813023540.GC6199@prunille.vinc17.org: 

> On 2007-08-12 20:57:13 +0000, zzapper wrote:
>> Hi

>> 
>> > mv x1 x2 x3 x4 x5 directory
> 
> Your mv is buggy. It must report the error and must not do any change
> on your files.
> 
Hi,
red face; in fact my mv does report "not a directory".
My problem is reduced to unintentionally moving a single file to another 
single file rather than the intended directory.

MM solves this by suggesting a trailing slash

$ mv x3 bucket/
mv: accessing `bucket/': Not a directory





-- 
zzapper
http://www.rayninfo.co.uk/vimtips.html

Re: the mv trap

[Vincent Lefevre]

On 2007-08-13 07:44:39 +0000, zzapper wrote:
> red face; in fact my mv does report "not a directory".
> My problem is reduced to unintentionally moving a single file to another 
> single file rather than the intended directory.
> 
> MM solves this by suggesting a trailing slash
> 
> $ mv x3 bucket/
> mv: accessing `bucket/': Not a directory

If you fear to forget the trailing slash, you can also write a shell
script/function that checks that the target is a directory, then
executes mv.

-- 
Vincent Lefèvre <vincent@vinc17.org> - Web: <http://www.vinc17.org/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.org/blog/>
Work: CR INRIA - computer arithmetic / Arenaire project (LIP, ENS-Lyon)

Re: the mv trap

[Stephane Chazelas]

On Mon, Aug 13, 2007 at 04:34:52PM +0200, Vincent Lefevre wrote:
> On 2007-08-13 07:44:39 +0000, zzapper wrote:
> > red face; in fact my mv does report "not a directory".
> > My problem is reduced to unintentionally moving a single file to another 
> > single file rather than the intended directory.
> > 
> > MM solves this by suggesting a trailing slash
> > 
> > $ mv x3 bucket/
> > mv: accessing `bucket/': Not a directory
> 
> If you fear to forget the trailing slash, you can also write a shell
> script/function that checks that the target is a directory, then
> executes mv.
[...]

The thing is you sometimes do want to rename files with mv. The
wrapper function could be made so as to check if there doesn't
exist a directory spelled like the last argument.

Something like:

mv() {
  local dest=$@[-1]
  if [[ ! -d $dest ]]; then
    local -a files
    setopt localoptions extendedglob
    files=((#a2)$dest(ND/))
    if (($#files)); then
      printf >&2 '"%s" doesn'\''t exist as a directory but\n' ${(V)dest}
      printf >&2 'there exist %d directory(ies) with a close name:\n' $#files
      local i
      for ((i = 1; i <= $#files; i++)); do
        printf >&2 ' %d "%s"\n' "$i" ${(V)files[i]}
      done
      printf >&2 'Would you like to move files to one of those instead (n12.)? [n] '
      local answer
      read answer
      if [[ $answer = [0-9]## ]]; then
        argv[-1]=$files[answer]
	set -x
      fi
    fi
  fi
  command mv "$@"
}

        

-- 
Stéphane