zsh-workers
 help / color / mirror / code / Atom feed
* [PATCH] Fix configure.ac to not to treate [ ] as quotes when using them in case
@ 2007-08-16  9:59 Roy Marples
  2007-08-16 10:55 ` Peter Stephenson
  0 siblings, 1 reply; 2+ messages in thread
From: Roy Marples @ 2007-08-16  9:59 UTC (permalink / raw)
  To: zsh-workers

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

Hi list.

Attached is a patch to fix configure on FreeBSD.
This is needed as it uses a shell case statement to test for specific
FreeBSD versions. When run through autotools, it strips the [ ] bit as
it thinks they are quotes.

This fixes Gentoo bug #188930.
http://bugs.gentoo.org/show_bug.cgi?id=188930

Thanks

Roy Marples

PS - I'm not subscribed to this list, so email me directly if you have
queries.

[-- Attachment #2: zsh-4.3.4-configure-changequote.patch --]
[-- Type: text/x-patch, Size: 694 bytes --]

diff -ur a/configure.ac b/configure.ac
--- a/configure.ac	2007-01-05 13:58:04 +0000
+++ b/configure.ac	2007-08-16 09:17:29 +0100
@@ -2249,6 +2249,10 @@
   zsh_cv_sys_elf=yes,
   zsh_cv_sys_elf=no,
   zsh_cv_sys_elf=yes)])
+  
+  # We use [0-9]* in case statements, so need to change quoting
+  changequote(, )
+
   DL_EXT="${DL_EXT=so}"
   if test x$zsh_cv_sys_elf = xyes; then
     case "$host" in
@@ -2352,6 +2356,10 @@
       esac
     ;;
   esac
+
+  # Done with our shell code, so restore autotools quoting
+  changequote([, ])
+  
   AC_CACHE_CHECK(if your dlsym() needs a leading underscore,
    zsh_cv_func_dlsym_needs_underscore,
    [echo failed >conftestval && cat >conftest.c <<EOM

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix configure.ac to not to treate [ ] as quotes when using them in case
  2007-08-16  9:59 [PATCH] Fix configure.ac to not to treate [ ] as quotes when using them in case Roy Marples
@ 2007-08-16 10:55 ` Peter Stephenson
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Stephenson @ 2007-08-16 10:55 UTC (permalink / raw)
  To: Roy Marples, zsh-workers

Roy Marples wrote:
> Attached is a patch to fix configure on FreeBSD.
> This is needed as it uses a shell case statement to test for specific
> FreeBSD versions. When run through autotools, it strips the [ ] bit as
> it thinks they are quotes.

Thanks, committed on the head of the main line (context is a little
different but nothing significant).

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-08-16 11:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-08-16  9:59 [PATCH] Fix configure.ac to not to treate [ ] as quotes when using them in case Roy Marples
2007-08-16 10:55 ` Peter Stephenson

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).