* Re: git-svn completion issue (patch)
@ 2007-10-18 19:53 Mikael Magnusson
2007-10-18 20:53 ` Clint Adams
0 siblings, 1 reply; 2+ messages in thread
From: Mikael Magnusson @ 2007-10-18 19:53 UTC (permalink / raw)
To: zsh-workers
On 16/10/2007, Mikael Magnusson <mikachu@gmail.com> wrote:
> % git-svn <tab>
> ---- no match for: `command'
>
> I opened up _git to have a look, it seems it checks if $state is
> command, then declares an array $commands, which it then goes ahead
> and never uses for anything. I don't know exactly what incantation of
> _arguments or similar needs to be done here so no patch this time.
I think I figured it out, it at least seems to work correctly.
http://git.mikachu.ath.cx/?p=zsh-cvs.git;a=commitdiff_plain;h=gitsvn
--- a/Completion/Unix/Command/_git
+++ b/Completion/Unix/Command/_git
@@ -2345,6 +2345,7 @@ _git-svn () {
'set-tree:commit given commit or tree to SVN repository'
'show-ignore:output corresponding .gitignore file of svn:ignore'
'commit-diff:commit diff of two tree-ishs')
+ _describe -t commands command commands && ret=0
;;
(options)
declare -a arguments
--
Mikael Magnusson
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: git-svn completion issue (patch)
2007-10-18 19:53 git-svn completion issue (patch) Mikael Magnusson
@ 2007-10-18 20:53 ` Clint Adams
0 siblings, 0 replies; 2+ messages in thread
From: Clint Adams @ 2007-10-18 20:53 UTC (permalink / raw)
To: Mikael Magnusson; +Cc: zsh-workers
On Thu, Oct 18, 2007 at 09:53:57PM +0200, Mikael Magnusson wrote:
> + _describe -t commands command commands && ret=0
Committed.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-18 20:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-18 19:53 git-svn completion issue (patch) Mikael Magnusson
2007-10-18 20:53 ` Clint Adams
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).