Failures in today's build

Failures in today's build

[Vin Shelton]

With today's build I'm seeing the following failure on my linux boxes:

/opt/src/zsh-2007-10-19/Test/V01zmodload.ztst: starting.
Segmentation fault (core dumped)

Apparently this is a result of a failed unloading of a module:

Running test: Unload the modules loaded by this test suite
ZTST_test: expecting status: 0
Input: /tmp/zsh.ztst.in.1099, output: /tmp/zsh.ztst.out.1099, error:
/tmp/zsh.ztst.te
rr.1099
Segmentation fault (core dumped)
make: [check] Error 139 (ignored)
rm -rf Modules .zcompdump


Here are the files that we're changed in my most recent cvs update:

P ChangeLog
P Completion/Unix/Command/_git
P Src/Modules/curses.c
P Src/Zle/zle_main.c
P Src/Zle/zle_refresh.c

  - Vin
-- 
The Journey by Mary Oliver
http://www.poemhunter.com/p/m/poem.asp?poet=6771&poem=30506

From zsh-workers-return-23996-mason-zsh=primenet.com.au@sunsite.dk Sat Oct 20 00:54:08 2007
Return-Path: <zsh-workers-return-23996-mason-zsh=primenet.com.au@sunsite.dk>
Delivered-To: mason-zsh@primenet.com.au
Received: (qmail 4968 invoked from network); 20 Oct 2007 00:53:39 -0000
X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS
	autolearn=unavailable version=3.2.3
Received: from ns2.primenet.com.au (HELO primenet.com.au) (@203.24.36.3)
  by ns1.primenet.com.au with (DHE-RSA-AES256-SHA encrypted) SMTP; 20 Oct 2007 00:53:39 -0000
Received: (qmail 11282 invoked from network); 19 Oct 2007 20:02:30 -0000
Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88)
  by ns2.melb.primenet.com.au with SMTP; 19 Oct 2007 20:02:30 -0000
Received-SPF: none (ns2.melb.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts)
Received: (qmail 63125 invoked from network); 19 Oct 2007 20:02:24 -0000
Received: from sunsite.dk (130.225.247.90)
  by a.mx.sunsite.dk with SMTP; 19 Oct 2007 20:02:24 -0000
Received: (qmail 23587 invoked by alias); 19 Oct 2007 20:02:20 -0000
Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm
Precedence: bulk
X-No-Archive: yes
Delivered-To: mailing list zsh-workers@sunsite.dk
X-Seq: 23996
Received: (qmail 23573 invoked from network); 19 Oct 2007 20:02:20 -0000
Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88)
  by sunsite.dk with SMTP; 19 Oct 2007 20:02:20 -0000
Received: (qmail 62832 invoked from network); 19 Oct 2007 20:02:20 -0000
Received: from hu-out-0506.google.com (72.14.214.231)
  by a.mx.sunsite.dk with SMTP; 19 Oct 2007 20:02:15 -0000
Received: by hu-out-0506.google.com with SMTP id 28so863531hug
        for <zsh-workers@sunsite.dk>; Fri, 19 Oct 2007 13:02:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=beta;
        h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition:x-google-sender-auth;
        bh=QeSkwvoxQtZZ2yDkhLlJ1ZZht60LHT+hciUp/1WiDx0=;
        b=SSXkxq5V1LLIyfZRlhguSuKxIHLdvm1Gx4w/604lUYBTqpmYqRDtwBFFlZmhkuh7zcceUxUtGG9L4X1QAzLD06NO9EDnvXVnROvC7d5h3kVtdZysJ1zBxdR1ClLa8m5i/ruLILHbwT4RzFC3L0b/NvoU5ks41eDpJ6xtwPWJIUE=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:sender:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition:x-google-sender-auth;
        b=tgp1U5ENIg+qQbC97ANCU9TqB5o/uMEGlYHR+75LJw8jUIpukMcZ7vhUS6JAhm4bE28ysuPlVGv1Ym4WOSR96bEfxaccEE7fhcgudBrqVBytUj4Da8vfC66udMCfSB6e58sCUbonGiPxE+C2KVTSX6eJBjBCtS+Un/DajZrv6IA=
Received: by 10.82.171.16 with SMTP id t16mr4402737bue.1192824134166;
        Fri, 19 Oct 2007 13:02:14 -0700 (PDT)
Received: by 10.82.155.3 with HTTP; Fri, 19 Oct 2007 13:02:14 -0700 (PDT)
Message-ID: <20a807210710191302o5bc328b2pab30d13195708195@mail.gmail.com>
Date: Fri, 19 Oct 2007 16:02:14 -0400
From: "Vin Shelton" <acs@alumni.princeton.edu>
Sender: ethersoft@gmail.com
To: "zsh workers" <zsh-workers@sunsite.dk>
Subject: Failures in today's build
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
X-Google-Sender-Auth: c9ca36eb45db4c55

With today's build I'm seeing the following failure on my linux boxes:

/opt/src/zsh-2007-10-19/Test/V01zmodload.ztst: starting.
Segmentation fault (core dumped)

Apparently this is a result of a failed unloading of a module:

Running test: Unload the modules loaded by this test suite
ZTST_test: expecting status: 0
Input: /tmp/zsh.ztst.in.1099, output: /tmp/zsh.ztst.out.1099, error:
/tmp/zsh.ztst.te
rr.1099
Segmentation fault (core dumped)
make: [check] Error 139 (ignored)
rm -rf Modules .zcompdump


Here are the files that we're changed in my most recent cvs update:

P ChangeLog
P Completion/Unix/Command/_git
P Src/Modules/curses.c
P Src/Zle/zle_main.c
P Src/Zle/zle_refresh.c

  - Vin
-- 
The Journey by Mary Oliver
http://www.poemhunter.com/p/m/poem.asp?poet=6771&poem=30506

Re: Failures in today's build

[Clint Adams]

On Fri, Oct 19, 2007 at 04:02:14PM -0400, Vin Shelton wrote:
> With today's build I'm seeing the following failure on my linux boxes:
> 
> /opt/src/zsh-2007-10-19/Test/V01zmodload.ztst: starting.
> Segmentation fault (core dumped)
> 
> Apparently this is a result of a failed unloading of a module:
> 
> Running test: Unload the modules loaded by this test suite
> ZTST_test: expecting status: 0
> Input: /tmp/zsh.ztst.in.1099, output: /tmp/zsh.ztst.out.1099, error:
> /tmp/zsh.ztst.te
> rr.1099
> Segmentation fault (core dumped)
> make: [check] Error 139 (ignored)
> rm -rf Modules .zcompdump

If you don't zcurses -i after zmodloading, the hash is not
initialized. Here's a quick fix:

Index: Src/Modules/curses.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/curses.c,v
retrieving revision 1.12
diff -u -r1.12 curses.c
--- Src/Modules/curses.c	18 Oct 2007 20:44:13 -0000	1.12
+++ Src/Modules/curses.c	19 Oct 2007 20:18:26 -0000
@@ -58,7 +58,7 @@
 static struct ttyinfo saved_tty_state;
 static struct ttyinfo curses_tty_state;
 static LinkList zcurses_windows;
-static HashTable zcurses_colorpairs;
+static HashTable zcurses_colorpairs = NULL;
 
 #define ZCURSES_ERANGE 1
 #define ZCURSES_EDEFINED 2
@@ -599,7 +599,8 @@
 cleanup_(Module m)
 {
     freelinklist(zcurses_windows, (FreeFunc) zcurses_free_window);
-    deletehashtable(zcurses_colorpairs);
+    if (zcurses_colorpairs)
+	deletehashtable(zcurses_colorpairs);
     return setfeatureenables(m, &module_features, NULL);
 }
 

Re: Failures in today's build

[Andrey Borzenkov]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

On Saturday 20 October 2007, Clint Adams wrote:
> -static HashTable zcurses_colorpairs;
> +static HashTable zcurses_colorpairs = NULL;

This is redundant. Static variables are required to be initialized to 0 which 
for pointers translates to NULL (whatever is NULL on current platform)

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]