* PATCH: guess what this about
@ 2007-10-29 10:30 Peter Stephenson
2007-10-29 12:10 ` PATCH: guess what this is about Peter Stephenson
0 siblings, 1 reply; 4+ messages in thread
From: Peter Stephenson @ 2007-10-29 10:30 UTC (permalink / raw)
To: Zsh hackers list
Solaris 8 curses doesn't support color; this currently causes a
segmentation violation.
I'm also having problems with borders and timeouts on the same system
which I may look at at some point.
Index: Src/Modules/curses.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/curses.c,v
retrieving revision 1.29
diff -u -r1.29 curses.c
--- Src/Modules/curses.c 28 Oct 2007 20:28:31 -0000 1.29
+++ Src/Modules/curses.c 29 Oct 2007 10:28:14 -0000
@@ -268,6 +268,10 @@
short f, b;
Colorpairnode cpn;
+ /* zcurses_colorpairs is only initialised if color is supported */
+ if (!zcurses_colorpairs)
+ return 1;
+
if (zc_color_phase==1 ||
!(cpn = (Colorpairnode) gethashnode(zcurses_colorpairs, colorpair))) {
zc_color_phase = 2;
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: PATCH: guess what this is about
2007-10-29 10:30 PATCH: guess what this about Peter Stephenson
@ 2007-10-29 12:10 ` Peter Stephenson
2007-10-29 15:11 ` Seth Kurtzberg
0 siblings, 1 reply; 4+ messages in thread
From: Peter Stephenson @ 2007-10-29 12:10 UTC (permalink / raw)
To: Zsh hackers list
On Mon, 29 Oct 2007 10:30:14 +0000
Peter Stephenson <pws@csr.com> wrote:
> I'm also having problems with borders and timeouts on the same system
> which I may look at at some point.
The problem with timeouts on Solaris 8 (which is rather antiquated anyway)
was they didn't get turned off. This fixes it, but it's a bit nasty, and
also it may mess up the settings in other windows, since the timeout is
supposed to be window-specific, so I'd rather not have to do it unless it's
absolutely necessary. In particularly it would be nice to test, so I'll
leave it out for a while.
It's really time I did something else.
Index: Src/Modules/curses.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/curses.c,v
retrieving revision 1.30
diff -u -r1.30 curses.c
--- Src/Modules/curses.c 29 Oct 2007 11:38:17 -0000 1.30
+++ Src/Modules/curses.c 29 Oct 2007 12:05:11 -0000
@@ -961,6 +961,15 @@
return 1;
}
+ if (to < 0) {
+ /*
+ * On Solaris turning a timeout off seems to be problematic.
+ * The following fixes it. It would nice to #ifdef, but
+ * it's a palaver to test for.
+ */
+ nocbreak();
+ cbreak();
+ }
wtimeout(w->win, to);
return 0;
}
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: PATCH: guess what this is about
2007-10-29 12:10 ` PATCH: guess what this is about Peter Stephenson
@ 2007-10-29 15:11 ` Seth Kurtzberg
2007-10-30 11:07 ` Peter Stephenson
0 siblings, 1 reply; 4+ messages in thread
From: Seth Kurtzberg @ 2007-10-29 15:11 UTC (permalink / raw)
To: 'Zsh hackers list'
-----Original Message-----
From: Peter Stephenson [mailto:pws@csr.com]
Sent: Monday, October 29, 2007 8:10 AM
To: Zsh hackers list
Subject: Re: PATCH: guess what this is about
On Mon, 29 Oct 2007 10:30:14 +0000
Peter Stephenson <pws@csr.com> wrote:
> I'm also having problems with borders and timeouts on the same system
> which I may look at at some point.
The problem with timeouts on Solaris 8 (which is rather antiquated anyway)
was they didn't get turned off. This fixes it, but it's a bit nasty, and
also it may mess up the settings in other windows, since the timeout is
supposed to be window-specific, so I'd rather not have to do it unless it's
absolutely necessary. In particularly it would be nice to test, so I'll
leave it out for a while.
It's really time I did something else.
Spending a lot of time on Solaris 8 does seem like a low return effort, but
lot's of people still use it.
Index: Src/Modules/curses.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/curses.c,v
retrieving revision 1.30
diff -u -r1.30 curses.c
--- Src/Modules/curses.c 29 Oct 2007 11:38:17 -0000 1.30
+++ Src/Modules/curses.c 29 Oct 2007 12:05:11 -0000
@@ -961,6 +961,15 @@
return 1;
}
+ if (to < 0) {
+ /*
+ * On Solaris turning a timeout off seems to be problematic.
+ * The following fixes it. It would nice to #ifdef, but
+ * it's a palaver to test for.
+ */
+ nocbreak();
+ cbreak();
+ }
wtimeout(w->win, to);
return 0;
}
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: PATCH: guess what this is about
2007-10-29 15:11 ` Seth Kurtzberg
@ 2007-10-30 11:07 ` Peter Stephenson
0 siblings, 0 replies; 4+ messages in thread
From: Peter Stephenson @ 2007-10-30 11:07 UTC (permalink / raw)
To: 'Zsh hackers list'
On Mon, 29 Oct 2007 11:11:47 -0400
"Seth Kurtzberg" <seth@cql.com> wrote:
> Spending a lot of time on Solaris 8 does seem like a low return effort, but
> lot's of people still use it.
Right. I've committed a version with more specific tests (Solaris but not
ncurses).
I should say that I'm not entirely sure about the character I/O set-up on
our Solaris 8 machine: the multibyte tests have never worked, whereas other
Solaris users haven't had problems, and I know for a fact someone's
installed a duff ncurses library (which I've compiled out but still doesn't
fill me with confidence).
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-10-30 11:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-29 10:30 PATCH: guess what this about Peter Stephenson
2007-10-29 12:10 ` PATCH: guess what this is about Peter Stephenson
2007-10-29 15:11 ` Seth Kurtzberg
2007-10-30 11:07 ` Peter Stephenson
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).