zsh-workers
 help / color / mirror / code / Atom feed
* _cp patch for --preserve and --no-preserve _values
@ 2007-11-09  9:58 Nikolai Weibull
  2007-11-18 20:35 ` Clint Adams
  0 siblings, 1 reply; 2+ messages in thread
From: Nikolai Weibull @ 2007-11-09  9:58 UTC (permalink / raw)
  To: zsh-workers

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

The calls to _values for --preserve and --no-preserve don't contain a
description.  This means that the value "mode" becomes the description
and is thus not completed.

[-- Attachment #2: _cp.patch --]
[-- Type: application/octet-stream, Size: 967 bytes --]

diff --git a/Completion/Unix/Command/_cp b/Completion/Unix/Command/_cp
index 8305c57..9838b17 100644
--- a/Completion/Unix/Command/_cp
+++ b/Completion/Unix/Command/_cp
@@ -12,8 +12,8 @@ _arguments -s \
   '(-l --link)'{-l,--link}'[link files instead of copying]' \
   '(-L --dereference)'{-L,--dereference}'[always follow symbolic links]' \
   '-p[same as --preserve=mode,ownership,timestamps]' \
-  '--preserve=:attributes to preserve:_values -s , mode ownership timestamps links all' \
-  '--no-preserve=:attributes not to preserve:_values -s , mode ownership timestamps links all' \
+  '--preserve=:attributes to preserve:_values -s , attribute mode ownership timestamps links all' \
+  '--no-preserve=:attributes not to preserve:_values -s , attribute mode ownership timestamps links all' \
   '--parents[append source path to target directory]' \
   '-P[same as --no-dereference]' \
   '(-R -r --recursive)'{-R,-r,--recursive}'[copy directories recursively]' \

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: _cp patch for --preserve and --no-preserve _values
  2007-11-09  9:58 _cp patch for --preserve and --no-preserve _values Nikolai Weibull
@ 2007-11-18 20:35 ` Clint Adams
  0 siblings, 0 replies; 2+ messages in thread
From: Clint Adams @ 2007-11-18 20:35 UTC (permalink / raw)
  To: Nikolai Weibull; +Cc: zsh-workers

On Fri, Nov 09, 2007 at 10:58:32AM +0100, Nikolai Weibull wrote:
> The calls to _values for --preserve and --no-preserve don't contain a
> description.  This means that the value "mode" becomes the description
> and is thus not completed.

Committed.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-11-18 20:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-11-09  9:58 _cp patch for --preserve and --no-preserve _values Nikolai Weibull
2007-11-18 20:35 ` Clint Adams

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).