Re: Bug#457076: zsh: is-at-least does not work properly

Re: Bug#457076: zsh: is-at-least does not work properly

[Clint Adams]

On Wed, Dec 19, 2007 at 05:15:09PM +0200, Tonguc Yumruk wrote:
> The is-at-least function in zsh (which is used in some other functions)
> uses setopt LOCAL_OPTIONS which is only available in ksh emulation mode.
> Instead it should use emulate -L zsh to use LOCAL_OPTIONS in zsh mode.
> Patch is attached.

What do you mean?

> 17c17
> < emulate zsh ; setopt LOCAL_OPTIONS
> ---
> > emulate -L zsh #; setopt LOCAL_OPTIONS

Re: Bug#457076: zsh: is-at-least does not work properly

[Peter Stephenson]

On Wed, 19 Dec 2007 14:19:34 -0500
Clint Adams <schizo@debian.org> wrote:
> On Wed, Dec 19, 2007 at 05:15:09PM +0200, Tonguc Yumruk wrote:
> > The is-at-least function in zsh (which is used in some other functions)
> > uses setopt LOCAL_OPTIONS which is only available in ksh emulation mode.
> > Instead it should use emulate -L zsh to use LOCAL_OPTIONS in zsh mode.
> > Patch is attached.

"setopt LOCAL_OPTIONS" should work fine in all modes.  If there are places
where it doesn't that's a bug.

It would be more consistent to use "emulate -L zsh" here but it's
exactly equivalent to what's there already.

-- 
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/

Re: Bug#457076: zsh: is-at-least does not work properly

[Tonguc Yumruk]

[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]

tonguc@terra:~% setopt LOCAL_OPTIONS
setopt: no such option: LOCAL_OPTIONS

On the other hand this works fine:

tonguc@terra:~% setopt localoptions

The ksh mode was my mistake. I misinterpreted the man page.

Thus saith Peter Stephenson :
> On Wed, 19 Dec 2007 14:19:34 -0500
> Clint Adams <schizo@debian.org> wrote:
> > On Wed, Dec 19, 2007 at 05:15:09PM +0200, Tonguc Yumruk wrote:
> > > The is-at-least function in zsh (which is used in some other functions)
> > > uses setopt LOCAL_OPTIONS which is only available in ksh emulation mode.
> > > Instead it should use emulate -L zsh to use LOCAL_OPTIONS in zsh mode.
> > > Patch is attached.
> 
> "setopt LOCAL_OPTIONS" should work fine in all modes.  If there are places
> where it doesn't that's a bug.
> 
> It would be more consistent to use "emulate -L zsh" here but it's
> exactly equivalent to what's there already.
> 
> -- 
> Peter Stephenson <p.w.stephenson@ntlworld.com>
> Web page now at http://homepage.ntlworld.com/p.w.stephenson/

-- 
Sevgi Saygı GNU/Linux
########################################################################
All seems condemned in the long run to approximate a state akin to
Gaussian noise.
		-- James Martin
########################################################################
Tonguç Yumruk

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: Bug#457076: zsh: is-at-least does not work properly

[Peter Stephenson]

On Wed, 19 Dec 2007 22:41:07 +0200
Tonguc Yumruk <tongucyumruk@fazlamesai.net> wrote:
> tonguc@terra:~% setopt LOCAL_OPTIONS
> setopt: no such option: LOCAL_OPTIONS
> 
> On the other hand this works fine:
> 
> tonguc@terra:~% setopt localoptions

I wonder if that's a function of your locale ($LANG setting)?  It's
possible it's not translating upper case characters to lower case
properly.  Ah, in fact it probably is...

2007-03-15  Peter Stephenson  <pws@csr.com>

	* 23219: Src/options.c: Ismail Dönmez reported that lower
	casing of I to dotless i in tr_TR.UTF-8 broke option handling.

I would guess you'll find that any option with an upper case I in it
won't work properly.

Now I look, I've found I've missed a place that needs this fix (although
it doesn't apply here).

Index: Src/options.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/options.c,v
retrieving revision 1.37
diff -u -r1.37 options.c
--- Src/options.c	18 Jun 2007 13:25:05 -0000	1.37
+++ Src/options.c	19 Dec 2007 21:46:08 -0000
@@ -571,7 +571,9 @@
 		if (*t == '_')
 		    chuck(t);
 		else {
-		    *t = tulower(*t);
+		    /* See comment in optlookup() */
+		    if (*t >= 'A' && *t <= 'Z')
+			*t = (*t - 'A') + 'a';
 		    t++;
 		}
 


-- 
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/

Re: Bug#457076: zsh: is-at-least does not work properly

[Ismail Dönmez]

Wednesday 19 December 2007 23:46:04 tarihinde şunları yazmıştınız:
> On Wed, 19 Dec 2007 22:41:07 +0200
>
> Tonguc Yumruk <tongucyumruk@fazlamesai.net> wrote:
> > tonguc@terra:~% setopt LOCAL_OPTIONS
> > setopt: no such option: LOCAL_OPTIONS
> >
> > On the other hand this works fine:
> >
> > tonguc@terra:~% setopt localoptions
>
> I wonder if that's a function of your locale ($LANG setting)?  It's
> possible it's not translating upper case characters to lower case
> properly.  Ah, in fact it probably is...
>
> 2007-03-15  Peter Stephenson  <pws@csr.com>
>
>         * 23219: Src/options.c: Ismail Dönmez reported that lower
>         casing of I to dotless i in tr_TR.UTF-8 broke option handling.

Yeah indeed, both  setopt LOCAL_OPTIONS and setopt localoptions work fine with 
tr_TR.UTF-8 locale here using zsh CVS.

Regards,
ismail

-- 
Never learn by your mistakes, if you do you may never dare to try again.