zsh-workers
 help / color / mirror / code / Atom feed
* _acroread completer updated for acroread 8.1.1
@ 2008-01-28  0:45 Haakon Riiser
  2008-02-10 22:12 ` Haakon Riiser
  2008-02-21 15:23 ` 3rd repost: " Haakon Riiser
  0 siblings, 2 replies; 4+ messages in thread
From: Haakon Riiser @ 2008-01-28  0:45 UTC (permalink / raw)
  To: zsh-workers

The changes between acroread 8.x and 7.x are really small: 8.x
supports -v as an alias for -version, plus two new options,
-man and -installCertificate.  This patch also adds support
for -stampsOff and -markupsOn, which seem to have been added
somewhere between 7.0.0 and 7.0.9.  Don't know exactly which
version introduced them, so this patch just adds them regardless
of which 7.x (or 8.x) version is used.

Index: _acroread
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/X/Command/_acroread,v
retrieving revision 1.7
diff -u -r1.7 _acroread
--- _acroread	1 Mar 2007 19:22:33 -0000	1.7
+++ _acroread	28 Jan 2008 00:39:40 -0000
@@ -26,8 +26,15 @@
   fi
 fi
 
-if [[ $_acroread_version == 7.* ]]; then
+if [[ $_acroread_version == [78].* ]]; then
+  local -a extra_args
+  if [[ $_acroread_version == 8.* ]]; then
+    extra_args=(-man '-installCertificate:server ip::server port')
+  else
+    extra_args=()
+  fi
   _arguments -C \
+    "${extra_args[@]}" \
     '--display=:X display:_x_display' \
     '--screen=:X screen (overrides the screen part of DISPLAY)' \
     --sync \
@@ -55,6 +62,8 @@
     '(-odd)-even' \
     -commentsOff \
     -annotsOff \
+    -stampsOff \
+    -markupsOn \
     '(-level3)-level2' \
     '(-level2)-level3' \
     -printerhalftones \

-- 
 Haakon


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: _acroread completer updated for acroread 8.1.1
  2008-01-28  0:45 _acroread completer updated for acroread 8.1.1 Haakon Riiser
@ 2008-02-10 22:12 ` Haakon Riiser
  2008-02-21 15:23 ` 3rd repost: " Haakon Riiser
  1 sibling, 0 replies; 4+ messages in thread
From: Haakon Riiser @ 2008-02-10 22:12 UTC (permalink / raw)
  To: zsh-workers; +Cc: p.w.stephenson

Reposting the below patch, now with cc to pws since CVS shows
that he committed the last change.

> The changes between acroread 8.x and 7.x are really small: 8.x
> supports -v as an alias for -version, plus two new options,
> -man and -installCertificate.  This patch also adds support
> for -stampsOff and -markupsOn, which seem to have been added
> somewhere between 7.0.0 and 7.0.9.  Don't know exactly which
> version introduced them, so this patch just adds them regardless
> of which 7.x (or 8.x) version is used.
> 
> Index: _acroread
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Completion/X/Command/_acroread,v
> retrieving revision 1.7
> diff -u -r1.7 _acroread
> --- _acroread	1 Mar 2007 19:22:33 -0000	1.7
> +++ _acroread	28 Jan 2008 00:39:40 -0000
> @@ -26,8 +26,15 @@
>    fi
>  fi
>  
> -if [[ $_acroread_version == 7.* ]]; then
> +if [[ $_acroread_version == [78].* ]]; then
> +  local -a extra_args
> +  if [[ $_acroread_version == 8.* ]]; then
> +    extra_args=(-man '-installCertificate:server ip::server port')
> +  else
> +    extra_args=()
> +  fi
>    _arguments -C \
> +    "${extra_args[@]}" \
>      '--display=:X display:_x_display' \
>      '--screen=:X screen (overrides the screen part of DISPLAY)' \
>      --sync \
> @@ -55,6 +62,8 @@
>      '(-odd)-even' \
>      -commentsOff \
>      -annotsOff \
> +    -stampsOff \
> +    -markupsOn \
>      '(-level3)-level2' \
>      '(-level2)-level3' \
>      -printerhalftones \
> 
> -- 
>  Haakon


^ permalink raw reply	[flat|nested] 4+ messages in thread

* 3rd repost: _acroread completer updated for acroread 8.1.1
  2008-01-28  0:45 _acroread completer updated for acroread 8.1.1 Haakon Riiser
  2008-02-10 22:12 ` Haakon Riiser
@ 2008-02-21 15:23 ` Haakon Riiser
  2008-02-21 16:08   ` Peter Stephenson
  1 sibling, 1 reply; 4+ messages in thread
From: Haakon Riiser @ 2008-02-21 15:23 UTC (permalink / raw)
  To: zsh-workers

Third time's the charm?  (If you don't want this one, please let me
know so that I can stop spamming the list.)

> The changes between acroread 8.x and 7.x are really small: 8.x
> supports -v as an alias for -version, plus two new options,
> -man and -installCertificate.  This patch also adds support
> for -stampsOff and -markupsOn, which seem to have been added
> somewhere between 7.0.0 and 7.0.9.  Don't know exactly which
> version introduced them, so this patch just adds them regardless
> of which 7.x (or 8.x) version is used.
> 
> Index: _acroread
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Completion/X/Command/_acroread,v
> retrieving revision 1.7
> diff -u -r1.7 _acroread
> --- _acroread	1 Mar 2007 19:22:33 -0000	1.7
> +++ _acroread	28 Jan 2008 00:39:40 -0000
> @@ -26,8 +26,15 @@
>    fi
>  fi
>  
> -if [[ $_acroread_version == 7.* ]]; then
> +if [[ $_acroread_version == [78].* ]]; then
> +  local -a extra_args
> +  if [[ $_acroread_version == 8.* ]]; then
> +    extra_args=(-man '-installCertificate:server ip::server port')
> +  else
> +    extra_args=()
> +  fi
>    _arguments -C \
> +    "${extra_args[@]}" \
>      '--display=:X display:_x_display' \
>      '--screen=:X screen (overrides the screen part of DISPLAY)' \
>      --sync \
> @@ -55,6 +62,8 @@
>      '(-odd)-even' \
>      -commentsOff \
>      -annotsOff \
> +    -stampsOff \
> +    -markupsOn \
>      '(-level3)-level2' \
>      '(-level2)-level3' \
>      -printerhalftones \
> 
> -- 
>  Haakon


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: 3rd repost: _acroread completer updated for acroread 8.1.1
  2008-02-21 15:23 ` 3rd repost: " Haakon Riiser
@ 2008-02-21 16:08   ` Peter Stephenson
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Stephenson @ 2008-02-21 16:08 UTC (permalink / raw)
  To: Haakon Riiser, zsh-workers

Haakon Riiser wrote:
> Third time's the charm?  (If you don't want this one, please let me
> know so that I can stop spamming the list.)

It's been committed for over a week.  You need to check the repository
or at least the ChangeLog.

> > Index: _acroread

It would also help if you could avoid the ">"'s in front of the patch.

Thanks.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-02-21 16:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-28  0:45 _acroread completer updated for acroread 8.1.1 Haakon Riiser
2008-02-10 22:12 ` Haakon Riiser
2008-02-21 15:23 ` 3rd repost: " Haakon Riiser
2008-02-21 16:08   ` Peter Stephenson

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).