zsh-workers
 help / color / mirror / code / Atom feed
From: Clint Adams <clint@zsh.org>
To: zsh-workers@sunsite.dk
Subject: ZSH_VERSIONSUFFIX [was Re: ZSH_EXTRAVERSION [was Re: Segfault with newer .zwc]]
Date: Thu, 31 Jan 2008 21:54:28 -0500	[thread overview]
Message-ID: <20080201025428.GA17388@scowler.net> (raw)
In-Reply-To: <20080122013517.GD16813@scowler.net>

On Mon, Jan 21, 2008 at 08:35:17PM -0500, Clint Adams wrote:
> +VERSION="$VERSION$ZSH_VERSIONSUFFIX"

So this actually doesn't work for reasons that should be obvious from
the ugly patch below. The suffix is lost in a ./config.status --recheck;
I don't know whether to view this as a feature or a bug.

Index: Makefile.in
===================================================================
RCS file: /cvsroot/zsh/zsh/Makefile.in,v
retrieving revision 1.17
diff -u -r1.17 Makefile.in
--- Makefile.in	16 Sep 2006 15:53:03 -0000	1.17
+++ Makefile.in	1 Feb 2008 02:49:07 -0000
@@ -29,6 +29,7 @@
 SUBDIRS = Doc Etc Src Test
 
 @VERSION_MK@
+VERSION = @VERSION@
 
 # source/build directories
 VPATH           = @srcdir@
Index: configure.ac
===================================================================
RCS file: /cvsroot/zsh/zsh/configure.ac,v
retrieving revision 1.89
diff -u -r1.89 configure.ac
--- configure.ac	22 Jan 2008 01:59:26 -0000	1.89
+++ configure.ac	1 Feb 2008 02:49:08 -0000
@@ -33,6 +33,7 @@
 . ${srcdir}/Config/version.mk
 VERSION="$VERSION$ZSH_VERSIONSUFFIX"
 echo "configuring for zsh $VERSION"
+AC_SUBST(VERSION)
 
 dnl ----------------------------------------------
 dnl CHECK FOR MACHINE/VENDOR/OPERATING SYSTEM TYPE
Index: Doc/Makefile.in
===================================================================
RCS file: /cvsroot/zsh/zsh/Doc/Makefile.in,v
retrieving revision 1.38
diff -u -r1.38 Makefile.in
--- Doc/Makefile.in	20 Nov 2007 14:20:00 -0000	1.38
+++ Doc/Makefile.in	1 Feb 2008 02:49:09 -0000
@@ -28,6 +28,7 @@
 dir_top = ..
 
 @VERSION_MK@
+VERSION = @VERSION@
 
 # source/build directories
 VPATH           = @srcdir@
Index: Etc/Makefile.in
===================================================================
RCS file: /cvsroot/zsh/zsh/Etc/Makefile.in,v
retrieving revision 1.2
diff -u -r1.2 Makefile.in
--- Etc/Makefile.in	3 Jul 2007 17:06:05 -0000	1.2
+++ Etc/Makefile.in	1 Feb 2008 02:49:09 -0000
@@ -29,6 +29,7 @@
 SUBDIRS =
 
 @VERSION_MK@
+VERSION = @VERSION@
 
 # source/build directories
 VPATH           = @srcdir@
Index: Src/Makefile.in
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Makefile.in,v
retrieving revision 1.13
diff -u -r1.13 Makefile.in
--- Src/Makefile.in	24 Jul 2005 04:47:57 -0000	1.13
+++ Src/Makefile.in	1 Feb 2008 02:49:09 -0000
@@ -29,6 +29,7 @@
 SUBDIRS =
 
 @VERSION_MK@
+VERSION = @VERSION@
 
 # source/build directories
 VPATH           = @srcdir@
Index: Src/Makemod.in.in
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Makemod.in.in,v
retrieving revision 1.5
diff -u -r1.5 Makemod.in.in
--- Src/Makemod.in.in	20 Dec 2001 23:48:39 -0000	1.5
+++ Src/Makemod.in.in	1 Feb 2008 02:49:09 -0000
@@ -31,6 +31,7 @@
 # SUBDIRS is done by mkmakemod.sh
 
 @VERSION_MK@
+VERSION = @VERSION@
 
 # source/build directories
 VPATH           = @srcdir@
Index: Test/Makefile.in
===================================================================
RCS file: /cvsroot/zsh/zsh/Test/Makefile.in,v
retrieving revision 1.9
diff -u -r1.9 Makefile.in
--- Test/Makefile.in	18 Dec 2007 21:16:30 -0000	1.9
+++ Test/Makefile.in	1 Feb 2008 02:49:09 -0000
@@ -29,6 +29,7 @@
 SUBDIRS = 
 
 @VERSION_MK@
+VERSION = @VERSION@
 
 # source/build directories
 VPATH           = @srcdir@


  reply	other threads:[~2008-02-01  2:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-07 17:39 Segfault with newer .zwc Jörg Sommer
2008-01-08  9:53 ` Peter Stephenson
2008-01-09 19:12   ` Clint Adams
2008-01-10  9:50     ` Peter Stephenson
2008-01-15  2:06       ` Clint Adams
2008-01-15  9:10         ` Peter Stephenson
2008-01-18 17:02           ` ZSH_EXTRAVERSION [was Re: Segfault with newer .zwc] Clint Adams
2008-01-21  1:48             ` Geoff Wing
2008-01-22  1:35               ` Clint Adams
2008-02-01  2:54                 ` Clint Adams [this message]
2008-02-01 11:22                   ` ZSH_VERSIONSUFFIX [was Re: ZSH_EXTRAVERSION [was Re: Segfault with newer .zwc]] Peter Stephenson
2008-02-01 11:28                     ` Peter Stephenson
2008-02-02  3:13                     ` Clint Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080201025428.GA17388@scowler.net \
    --to=clint@zsh.org \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).