From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: ZSH_VERSIONSUFFIX [was Re: ZSH_EXTRAVERSION [was Re: Segfault with newer .zwc]]
Date: Fri, 01 Feb 2008 11:22:10 +0000 [thread overview]
Message-ID: <200802011122.m11BMBdK025403@news01.csr.com> (raw)
In-Reply-To: <20080201025428.GA17388@scowler.net>
Clint Adams wrote:
> On Mon, Jan 21, 2008 at 08:35:17PM -0500, Clint Adams wrote:
> > +VERSION="$VERSION$ZSH_VERSIONSUFFIX"
>
> So this actually doesn't work for reasons that should be obvious from
> the ugly patch below. The suffix is lost in a ./config.status --recheck;
> I don't know whether to view this as a feature or a bug.
After updating the version in Config/version.mk and running make, I now
have a top level Makefile containing:
VERSION=4.3.5
VERSION_DATE='February 1, 2008'
VERSION = 4.3.4-dev-8
so (i) the dependencies aren't right (ii) the new VERSION doesn't fit
with the version generated from version.mk---the way to import a VERSION
definition into makefiles and scripts is @VERSION_MK@. I suspect you
want to do something like add ${ZSH_VERSIONSUFFIX} in version.mk (note
this needs to work in both shell scripts and Makefiles).
I don't want to wait yet more for 4.3.5, and obviously this isn't a
problem for a production version (though multiple definitions of the
version is), so I'll simply back this off for now.
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
next prev parent reply other threads:[~2008-02-01 11:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 17:39 Segfault with newer .zwc Jörg Sommer
2008-01-08 9:53 ` Peter Stephenson
2008-01-09 19:12 ` Clint Adams
2008-01-10 9:50 ` Peter Stephenson
2008-01-15 2:06 ` Clint Adams
2008-01-15 9:10 ` Peter Stephenson
2008-01-18 17:02 ` ZSH_EXTRAVERSION [was Re: Segfault with newer .zwc] Clint Adams
2008-01-21 1:48 ` Geoff Wing
2008-01-22 1:35 ` Clint Adams
2008-02-01 2:54 ` ZSH_VERSIONSUFFIX [was Re: ZSH_EXTRAVERSION [was Re: Segfault with newer .zwc]] Clint Adams
2008-02-01 11:22 ` Peter Stephenson [this message]
2008-02-01 11:28 ` Peter Stephenson
2008-02-02 3:13 ` Clint Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802011122.m11BMBdK025403@news01.csr.com \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).