zsh-workers
 help / color / mirror / code / Atom feed
From: Clint Adams <schizo@debian.org>
To: Romain Francoise <rfrancoise@debian.org>, 468384@bugs.debian.org
Cc: zsh-workers@sunsite.dk
Subject: Re: Bug#468384: zsh-beta: 'git bisect' completion incomplete
Date: Thu, 28 Feb 2008 12:12:14 -0500	[thread overview]
Message-ID: <20080228171214.GA11511@scowler.net> (raw)
In-Reply-To: <874pbtf295.fsf@elegiac.orebokech.com>

On Thu, Feb 28, 2008 at 05:56:54PM +0100, Romain Francoise wrote:
> zsh-beta's git completion code doesn't know about 'git bisect skip'
> and 'git bisect run'.

I think this whole case block should be cleaned up to not use
_arguments.

Index: Completion/Unix/Command/_git
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_git,v
retrieving revision 1.59
diff -u -r1.59 _git
--- Completion/Unix/Command/_git	25 Jan 2008 13:56:04 -0000	1.59
+++ Completion/Unix/Command/_git	28 Feb 2008 17:11:17 -0000
@@ -1395,6 +1395,8 @@
     reset:"finish bisection search and return to the given branch (or master)"
     start:"reset bisection state and start a new bisection"
     visualize:"show the remaining revisions in gitk"
+    skip:"choose a nearby commit"
+    run:"run evaluation script"
   )
 
   if (( CURRENT == 2 )); then
@@ -1405,7 +1407,7 @@
         _arguments \
           '2:revision:__git_commits' && ret=0
         ;;
-      (good)
+      (good|skip)
         _arguments \
           '*:revision:__git_commits' && ret=0
         ;;
@@ -1417,6 +1419,11 @@
         _arguments \
           '2:branch:__git_heads' && ret=0
         ;;
+      (run)
+        _arguments \
+          '*::arguments: _normal' && ret=0
+        ;;
+
       (*)
         _nothing
         ;;


           reply	other threads:[~2008-02-28 17:12 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <874pbtf295.fsf@elegiac.orebokech.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080228171214.GA11511@scowler.net \
    --to=schizo@debian.org \
    --cc=468384@bugs.debian.org \
    --cc=rfrancoise@debian.org \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).