zsh-workers
 help / color / mirror / code / Atom feed
* Re: Bug#468384: zsh-beta: 'git bisect' completion incomplete
       [not found] <874pbtf295.fsf@elegiac.orebokech.com>
@ 2008-02-28 17:12 ` Clint Adams
  0 siblings, 0 replies; only message in thread
From: Clint Adams @ 2008-02-28 17:12 UTC (permalink / raw)
  To: Romain Francoise, 468384; +Cc: zsh-workers

On Thu, Feb 28, 2008 at 05:56:54PM +0100, Romain Francoise wrote:
> zsh-beta's git completion code doesn't know about 'git bisect skip'
> and 'git bisect run'.

I think this whole case block should be cleaned up to not use
_arguments.

Index: Completion/Unix/Command/_git
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_git,v
retrieving revision 1.59
diff -u -r1.59 _git
--- Completion/Unix/Command/_git	25 Jan 2008 13:56:04 -0000	1.59
+++ Completion/Unix/Command/_git	28 Feb 2008 17:11:17 -0000
@@ -1395,6 +1395,8 @@
     reset:"finish bisection search and return to the given branch (or master)"
     start:"reset bisection state and start a new bisection"
     visualize:"show the remaining revisions in gitk"
+    skip:"choose a nearby commit"
+    run:"run evaluation script"
   )
 
   if (( CURRENT == 2 )); then
@@ -1405,7 +1407,7 @@
         _arguments \
           '2:revision:__git_commits' && ret=0
         ;;
-      (good)
+      (good|skip)
         _arguments \
           '*:revision:__git_commits' && ret=0
         ;;
@@ -1417,6 +1419,11 @@
         _arguments \
           '2:branch:__git_heads' && ret=0
         ;;
+      (run)
+        _arguments \
+          '*::arguments: _normal' && ret=0
+        ;;
+
       (*)
         _nothing
         ;;


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-02-28 17:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <874pbtf295.fsf@elegiac.orebokech.com>
2008-02-28 17:12 ` Bug#468384: zsh-beta: 'git bisect' completion incomplete Clint Adams

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).