zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: PATCH: isearch match highlighting
Date: Mon, 28 Apr 2008 10:20:01 +0100	[thread overview]
Message-ID: <20080428102001.7b55074e@news01> (raw)
In-Reply-To: <17393e3e0804271849l30fe20bdp4008fc8247298d12@mail.gmail.com>

On Sun, 27 Apr 2008 21:49:01 -0400
"Matt Wozniski" <godlygeek@gmail.com> wrote:
> Yep, works now - and looks very nice, though I wonder if we could set
> it up in a way that would let us change the fg or bg color of the
> text, rather than just reverse/standout/underline?

I should get around to that before long.  I don't think it should be too
hard.  I'd like to use standard termcap AF/AB codes for this instead of the
hacked-in (surprise!) colors we currently use in completion, but it doesn't
seem to be that easy to set defaults etc. that way.  Maybe Geoff knows
about this.

> That said, I found a regression in history-incremental-search-backward
> that's in CVS but not 4.3.6, so my guess is that it's caused by
> something in this patch (though I didn't back this patch out to
> double-check that assumption - I'm not very good at working with CVS).
> 
> zsh -f
> mastermind% bindkey -e
> mastermind% ^R-ff^H^He
> failing bck-i-search: -e_
> if you backspace again and retype the e, it changes to a succeeding bck-i-search
> then, ^G and do
> mastermind% ^R-f^He
> bck-i-search: -e_
> 
> So, whatever the bug is, it seems to require more than one backspace
> to trigger it for some reason...

I've seen something like this, but unfortunately I can't get it to happen
reproducibly.  Something might not be being initialised properly.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


  reply	other threads:[~2008-04-28  9:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-26 22:48 Peter Stephenson
2008-04-27  0:27 ` Matt Wozniski
2008-04-27 16:48   ` Bart Schaefer
2008-04-27 19:57   ` Peter Stephenson
2008-04-28  1:49     ` Matt Wozniski
2008-04-28  9:20       ` Peter Stephenson [this message]
2008-04-28 10:50         ` Matt Wozniski
2008-04-28 11:02           ` Peter Stephenson
2008-04-29 17:10         ` Peter Stephenson
2008-04-29 20:12           ` Matt Wozniski
2008-04-29 20:21             ` Matt Wozniski
2008-05-01 10:37           ` Peter Stephenson
2008-05-02 10:49             ` Nikolai Weibull
2008-05-02 11:14               ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080428102001.7b55074e@news01 \
    --to=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).