zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@csr.com>
To: zsh-workers@sunsite.dk
Subject: Re: PATCH: isearch match highlighting
Date: Mon, 28 Apr 2008 12:02:59 +0100	[thread overview]
Message-ID: <200804281103.m3SB2xS7020865@news01.csr.com> (raw)
In-Reply-To: <17393e3e0804280350h165f0466mb2776d9ff7ca03ae@mail.gmail.com>

"Matt Wozniski" wrote:
> I think that the right fix is just unconditionally resetting skip_pos
> right before we conditionally set it.

Thanks, that looks fine and I even know basically why: I just added the
"nosearch" variable to optimise out a search when we're backtracking
since we know whether it succeeded or failed at the position in
question.  That means skip_pos isn't handled quite the same way it used
to be, since it's in the optimised out code, and in particular it isn't
reset when we don't search (before it would have been even on a
failure).  As you've reset it at exactly the point nosearch is set I
think that should cover everything.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


  reply	other threads:[~2008-04-28 11:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-26 22:48 Peter Stephenson
2008-04-27  0:27 ` Matt Wozniski
2008-04-27 16:48   ` Bart Schaefer
2008-04-27 19:57   ` Peter Stephenson
2008-04-28  1:49     ` Matt Wozniski
2008-04-28  9:20       ` Peter Stephenson
2008-04-28 10:50         ` Matt Wozniski
2008-04-28 11:02           ` Peter Stephenson [this message]
2008-04-29 17:10         ` Peter Stephenson
2008-04-29 20:12           ` Matt Wozniski
2008-04-29 20:21             ` Matt Wozniski
2008-05-01 10:37           ` Peter Stephenson
2008-05-02 10:49             ` Nikolai Weibull
2008-05-02 11:14               ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804281103.m3SB2xS7020865@news01.csr.com \
    --to=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).