From: Peter Stephenson <pws@csr.com>
To: zsh-workers <zsh-workers@sunsite.dk>
Subject: Re: describe-key-briefly crashes in cvs
Date: Tue, 29 Apr 2008 09:40:09 +0100 [thread overview]
Message-ID: <20080429094009.473ea68e@news01> (raw)
In-Reply-To: <237967ef0804281126x66554276o918f5b2ea0c105df@mail.gmail.com>
Probably I should never have made unmetafying in place the default
behaviour for stringaszleline().
Index: Src/Zle/zle_refresh.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_refresh.c,v
retrieving revision 1.62
diff -u -r1.62 zle_refresh.c
--- Src/Zle/zle_refresh.c 26 Apr 2008 22:52:51 -0000 1.62
+++ Src/Zle/zle_refresh.c 29 Apr 2008 08:38:08 -0000
@@ -1418,8 +1418,9 @@
if (statusline) {
int outll, outsz;
+ char *statusdup = ztrdup(statusline);
ZLE_STRING_T outputline =
- stringaszleline(statusline, 0, &outll, &outsz, NULL);
+ stringaszleline(statusdup, 0, &outll, &outsz, NULL);
rpms.tosln = rpms.ln + 1;
nbuf[rpms.ln][winw + 1] = zr_zr; /* text not wrapped */
@@ -1484,6 +1485,7 @@
snextline(&rpms);
}
zfree(outputline, outsz);
+ free(statusdup);
}
*rpms.s = zr_zr;
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
prev parent reply other threads:[~2008-04-29 8:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 18:26 Mikael Magnusson
2008-04-29 8:40 ` Peter Stephenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080429094009.473ea68e@news01 \
--to=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).