PATCH: memory leak in bin_ztcp

PATCH: memory leak in bin_ztcp

[Clint Adams]

CID 85.

remotename is only used in the printf which follows, so there's no need to
duplicate the string.

Index: Src/Modules/tcp.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/tcp.c,v
retrieving revision 1.47
diff -u -r1.47 tcp.c
--- Src/Modules/tcp.c	12 Jul 2007 03:09:13 -0000	1.47
+++ Src/Modules/tcp.c	1 Nov 2008 18:13:42 -0000
@@ -570,7 +570,7 @@
 		    if (ztpeer)
 			remotename = ztpeer->h_name;
 		    else
-			remotename = ztrdup(inet_ntoa(sess->peer.in.sin_addr));
+			remotename = inet_ntoa(sess->peer.in.sin_addr);
 		    if (OPT_ISSET(ops,'L')) {
 			int schar;
 			if (sess->flags & ZTCP_ZFTP)

Re: PATCH: memory leak in bin_ztcp

[Clint Adams]

On Sat, Nov 01, 2008 at 06:16:13PM +0000, Clint Adams wrote:
> CID 85.
> 
> remotename is only used in the printf which follows, so there's no need to
> duplicate the string.

Missed one.

Index: Src/Modules/tcp.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/tcp.c,v
retrieving revision 1.48
diff -u -r1.48 tcp.c
--- Src/Modules/tcp.c	1 Nov 2008 18:20:14 -0000	1.48
+++ Src/Modules/tcp.c	6 Nov 2008 01:17:38 -0000
@@ -565,7 +565,7 @@
 		    if (zthost)
 			localname = zthost->h_name;
 		    else
-			localname = ztrdup(inet_ntoa(sess->sock.in.sin_addr));
+			localname = inet_ntoa(sess->sock.in.sin_addr);
 		    ztpeer = gethostbyaddr((const void *)&(sess->peer.in.sin_addr), sizeof(sess->peer.in.sin_addr), AF_INET);
 		    if (ztpeer)
 			remotename = ztpeer->h_name;