History file corruption on NFS

History file corruption on NFS

[Richard Hartmann]

Hi Vincent,

in your bug report[1] about zsh using the wrong kind of lock
in lockhistfile, you mentioned wanting to look into the
issue. Did you have time to do that? If not, could you do
a quick test to see if the issue is still open? I don't use NFS
currently, so there is no quick way for me to check.


Thanks,
Richard

[1]  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=412875

Re: History file corruption on NFS

[Vincent Lefevre]

On 2008-12-31 16:58:18 +0100, Richard Hartmann wrote:
> in your bug report[1] about zsh using the wrong kind of lock
> in lockhistfile, you mentioned wanting to look into the
> issue. Did you have time to do that?

The problem has been fixed upstream. See the following thread:

  http://www.zsh.org/mla/workers/2008/msg00479.html

Wayne Davison wrote a simpler patch, which was included in zsh on
2008-05-04, after version 4.3.6. It works in practice and I've also
just re-checked the code. AFAIK, this patch hasn't been backported
to Debian's package (I didn't see a HIST_FCNTL_LOCK option in the
package version 4.3.6-7). So, the Debian bug should remain open.

-- 
Vincent Lefèvre <vincent@vinc17.org> - Web: <http://www.vinc17.org/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.org/blog/>
Work: CR INRIA - computer arithmetic / Arenaire project (LIP, ENS-Lyon)

Re: History file corruption on NFS

[Richard Hartmann]

On Thu, Jan 1, 2009 at 05:19, Vincent Lefevre <vincent@vinc17.org> wrote:

> The problem has been fixed upstream. See the following thread:
>
>  http://www.zsh.org/mla/workers/2008/msg00479.html

Thanks.


> AFAIK, this patch hasn't been backported
> to Debian's package (I didn't see a HIST_FCNTL_LOCK option in the
> package version 4.3.6-7). So, the Debian bug should remain open.

Did you check 4.3.9-1, as well?


Richard

Re: History file corruption on NFS

[Vincent Lefevre]

On 2009-01-01 15:05:59 +0100, Richard Hartmann wrote:
> On Thu, Jan 1, 2009 at 05:19, Vincent Lefevre <vincent@vinc17.org> wrote:
> > AFAIK, this patch hasn't been backported
> > to Debian's package (I didn't see a HIST_FCNTL_LOCK option in the
> > package version 4.3.6-7). So, the Debian bug should remain open.
> 
> Did you check 4.3.9-1, as well?

I can't install Debian packages on machines where I have an account
under NFS (no root access). Anyway, I could check that the upstream
version (at least 4.3.8) solved the problem. So, something related
to the history has been modified in the Debian, I suppose it is fixed
as well in 4.3.9-1 (the HIST_FCNTL_LOCK option is listed).

-- 
Vincent Lefèvre <vincent@vinc17.org> - Web: <http://www.vinc17.org/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.org/blog/>
Work: CR INRIA - computer arithmetic / Arenaire project (LIP, ENS-Lyon)

Re: History file corruption on NFS

[Richard Hartmann]

Version: 4.3.9-1

On Thu, Jan 1, 2009 at 18:27, Vincent Lefevre <vincent@vinc17.org> wrote:

> Anyway, I could check that the upstream
> version (at least 4.3.8) solved the problem. So, something related
> to the history has been modified in the Debian, I suppose it is fixed
> as well in 4.3.9-1 (the HIST_FCNTL_LOCK option is listed).

Cool, thanks for checking. I closed the bug.


Richard