Autoload syntax error causes heap bug warning

Autoload syntax error causes heap bug warning

[Bart Schaefer]

torch% fpath=(/tmp/test $fpath)
torch% . /tmp/test/cause_bug
/tmp/test/cause_bug:3: parse error near `\n'
torch% autoload cause_bug
torch% compdef cause_bug foo
torch% foo <TAB>
cause_bug:3: parse error near `\n'
7: Src/mem.c:217: BUG: old_heaps() with pushed heaps

torch% cat /tmp/test/cause_bug
: deliberate sytax error:
while
torch% 

Re: Autoload syntax error causes heap bug warning

[Peter Stephenson]

On Mon, 6 Jun 2011 06:59:28 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> 7: Src/mem.c:217: BUG: old_heaps() with pushed heaps

I've seen lots of these over the years and never had time to
investigate, although part of the problem was reproducibility.

pws


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog

Re: Autoload syntax error causes heap bug warning

[Peter Stephenson]

On Mon, 06 Jun 2011 06:59:28 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> torch% autoload cause_bug
> torch% compdef cause_bug foo
> torch% foo <TAB>
> cause_bug:3: parse error near `\n'
> 7: Src/mem.c:217: BUG: old_heaps() with pushed heaps
> 
> torch% cat /tmp/test/cause_bug
> : deliberate sytax error:
> while

So this is what's been causing all those years of error messages from
failed autoloads...

I'll look for more missing popheap()s.

Index: Src/exec.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/exec.c,v
retrieving revision 1.197
diff -p -u -r1.197 exec.c
--- Src/exec.c	19 Jun 2011 20:12:00 -0000	1.197
+++ Src/exec.c	23 Jun 2011 19:14:53 -0000
@@ -4343,6 +4343,7 @@ loadautofn(Shfunc shf, int fksh, int aut
     }
     if (!prog) {
 	zsfree(fname);
+	popheap();
 	return NULL;
     }
     if (ksh == 2 || (ksh == 1 && isset(KSHAUTOLOAD))) {

-- 
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/