zsh-workers
 help / color / mirror / code / Atom feed
From: Phil Pennock <zsh-workers+phil.pennock@spodhuis.org>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: zsh-workers@zsh.org
Subject: Re: 5.0.3 +* -> git completion regression
Date: Tue, 17 Dec 2013 12:48:10 -0500	[thread overview]
Message-ID: <20131217174810.GA82157@redoubt.spodhuis.org> (raw)
In-Reply-To: <20131216220845.2108e18b@pws-pc.ntlworld.com>

On 2013-12-16 at 22:08 +0000, Peter Stephenson wrote:
> Thanks.  This is an efficient fix, so I hope it's good enough --- I've
> added a regression test, and it seems to be.
> 
> Another good workout with some sh scripts or functions would be useful.

Appears to work for me in practice; while I haven't tested extensively
(I don't have a test suite of all the things I do), one thing did crop
up.

I was confused over zsh versions after installing with this patch, but
config.log shows:

configure:14406: WARNING: unrecognized options: --enable-local-patchlevel

It looks like it's spelt --enable-custom-patchlevel so the INSTALL file
is wrong.

>From 6335389a59f5ec79154923fe8105aad4d846df25 Mon Sep 17 00:00:00 2001
From: Phil Pennock <pdpennock@users.sourceforge.net>
Date: Tue, 17 Dec 2013 12:43:17 -0500
Subject: [PATCH] Fix --enable-custom-patchlevel name in INSTALL

---
 INSTALL | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/INSTALL b/INSTALL
index 00791cd..99895bd 100644
--- a/INSTALL
+++ b/INSTALL
@@ -297,7 +297,7 @@ Modified versions of zsh
 If you are making local modifications to zsh, you are strongly
 advised to configure with the option
 
-  --enable-local-patchlevel="<my-mod-string>"
+  --enable-custom-patchlevel="<my-mod-string>"
 
 so that the variable $ZSH_PATCHLEVEL indicates this is not a standard
 version of the shell.  The argument is arbitrary, but should indicate
-- 
1.8.5.1



      reply	other threads:[~2013-12-17 17:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16  8:14 Phil Pennock
2013-12-16  9:47 ` Peter Stephenson
2013-12-16 10:37   ` Phil Pennock
2013-12-16 15:56     ` Bart Schaefer
2013-12-16 22:08     ` Peter Stephenson
2013-12-17 17:48       ` Phil Pennock [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131217174810.GA82157@redoubt.spodhuis.org \
    --to=zsh-workers+phil.pennock@spodhuis.org \
    --cc=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).