zsh-workers
 help / color / mirror / code / Atom feed
* [PATCH] configure.ac: expand all paths in the summary
@ 2014-09-20  9:11 Tanu Kaskinen
  2014-09-22 13:31 ` Peter Stephenson
  0 siblings, 1 reply; 2+ messages in thread
From: Tanu Kaskinen @ 2014-09-20  9:11 UTC (permalink / raw)
  To: zsh-workers

This fixes a cosmetic issue in the configure summary text. When I ran
"./configure --prefix=/home/tanu/tmp/zsh", the paths were printed as
follows:

binary install path       : /home/tanu/tmp/zsh/bin
man page install path     : ${prefix}/share/man
info install path         : ${prefix}/share/info
functions install path    : ${prefix}/share/zsh/5.0.6-dev-0/functions

After this patch, the paths are printed as follows:

binary install path       : /home/tanu/tmp/zsh/bin
man page install path     : /home/tanu/tmp/zsh/share/man
info install path         : /home/tanu/tmp/zsh/share/info
functions install path    : /home/tanu/tmp/zsh/share/zsh/5.0.6-dev-0/functions
---
 configure.ac | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/configure.ac b/configure.ac
index 37f3585..268e56f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3181,9 +3181,12 @@ AC_OUTPUT
 
 eval "zshbin1=${bindir}"
 eval "zshbin2=${zshbin1}"
-eval "zshman=${mandir}"
-eval "zshinfo=${infodir}"
-eval "zshfndir=${fndir}"
+eval "zshman1=${mandir}"
+eval "zshman2=${zshman1}"
+eval "zshinfo1=${infodir}"
+eval "zshinfo2=${zshinfo1}"
+eval "zshfndir1=${fndir}"
+eval "zshfndir2=${zshfndir1}"
 
 echo "
 zsh configuration
@@ -3208,10 +3211,10 @@ echo "\
 library flags             : ${LIBS}
 installation basename     : ${tzsh_name}
 binary install path       : ${zshbin2}
-man page install path     : ${zshman}
-info install path         : ${zshinfo}"
-if test "$zshfndir" != no; then
-  echo "functions install path    : ${zshfndir}"
+man page install path     : ${zshman2}
+info install path         : ${zshinfo2}"
+if test "$zshfndir2" != no; then
+  echo "functions install path    : ${zshfndir2}"
 fi
 if test "x$additionalfpath" != x; then
   echo "additional fpath entries  : ${additionalfpath}"
-- 
1.9.3


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] configure.ac: expand all paths in the summary
  2014-09-20  9:11 [PATCH] configure.ac: expand all paths in the summary Tanu Kaskinen
@ 2014-09-22 13:31 ` Peter Stephenson
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Stephenson @ 2014-09-22 13:31 UTC (permalink / raw)
  To: zsh-workers

On Sat, 20 Sep 2014 12:11:27 +0300
Tanu Kaskinen <tanu.kaskinen@linux.intel.com> wrote:
> This fixes a cosmetic issue in the configure summary text.

Thanks, I've committed it.

Entirely irrelevantly...

>  eval "zshbin1=${bindir}"
>  eval "zshbin2=${zshbin1}"
> -eval "zshman=${mandir}"
> -eval "zshinfo=${infodir}"
> -eval "zshfndir=${fndir}"
> +eval "zshman1=${mandir}"
> +eval "zshman2=${zshman1}"
> +eval "zshinfo1=${infodir}"
> +eval "zshinfo2=${zshinfo1}"
> +eval "zshfndir1=${fndir}"
> +eval "zshfndir2=${zshfndir1}"

Hmmm... this is where I should really be testing for the value of the
site function directory, so I don't need all the funny cases.  It's a
bit late, but it could stand a bit of moving around.  I can't be bothered
to revisit it, though.

pws


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-09-22 13:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-20  9:11 [PATCH] configure.ac: expand all paths in the summary Tanu Kaskinen
2014-09-22 13:31 ` Peter Stephenson

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).