PATCH: more math completion

PATCH: more math completion

[Peter Stephenson]

% echo $((3*4)<TAB>

causes a segmentation violation.  Looks like we're trying to extend the
raw buffer where we've attempted (and failed) to find a math expression
when we have no business doing so.

pws

diff --git a/Src/input.c b/Src/input.c
index 613f89a..1efabad 100644
--- a/Src/input.c
+++ b/Src/input.c
@@ -222,7 +222,8 @@ ingetc(void)
 	if (inputline())
 	    break;
     }
-    zshlex_raw_add(lastc);
+    if (!lexstop)
+	zshlex_raw_add(lastc);
     return lastc;
 }
 

Re: PATCH: more math completion

[Axel Beckert]

Hi Peter,

On Sat, Jul 25, 2015 at 09:46:06PM +0100, Peter Stephenson wrote:
> % echo $((3*4)<TAB>
> 
> causes a segmentation violation.  Looks like we're trying to extend the
> raw buffer where we've attempted (and failed) to find a math expression
> when we have no business doing so.

Thanks for that fix! I just ran into this issue when preparing a
Debian zsh package with the two $((…)) completions fixed. I'll include
that one, too.

Looks like another reason for a 5.0.9 rather soon as this one is
present in 5.0.8, too.

P.S.: Also thanks for the pointer to the fix for segfault reported in
      Debian against 5.0.8.

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | abe@deuxchevaux.org  (Mail)
 X   See http://www.nonhtmlmail.org/campaign.html | abe@noone.org (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://abe.noone.org/ (Web)