zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Wieland Hoffmann <themineo@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] _git: Quote the return value of __git_committish_range{first,last}
Date: Thu, 13 Aug 2015 23:18:42 +0000	[thread overview]
Message-ID: <20150813231842.GD1998@tarsus.local2> (raw)
In-Reply-To: <1439372177-32218-1-git-send-email-themineo@gmail.com>

Wieland Hoffmann wrote on Wed, Aug 12, 2015 at 11:36:17 +0200:
> Otherwise, __git_is_committish_range performs word splitting if it's
> passed a range that includes spaces (like "master@{1 week ago}..master").
...
> -  local first=$(__git_committish_range_first $1)
> -  local last=$(__git_committish_range_last $1)
> +  local first="$(__git_committish_range_first $1)"
> +  local last="$(__git_committish_range_last $1)"

I see this has been applied, but for future reference, note that it is
only necessary for 5.0.8 and older, since in zsh from git 'local' is
a reserved word and
    local x=$(echo foo bar)
doesn't perform word splitting.

Cheers,

Daniel


      reply	other threads:[~2015-08-13 23:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-12  9:36 Wieland Hoffmann
2015-08-13 23:18 ` Daniel Shahaf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150813231842.GD1998@tarsus.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=themineo@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).