From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: zsh-workers@zsh.org
Subject: Re: PRINT_EXIT_VALUE: Suppress for if/while conditions
Date: Mon, 17 Aug 2015 22:00:36 +0000 [thread overview]
Message-ID: <20150817220036.GB2283@tarsus.local2> (raw)
In-Reply-To: <20150814091945.2b048787@pwslap01u.europe.root.pri>
Peter Stephenson wrote on Fri, Aug 14, 2015 at 09:19:45 +0100:
> On Thu, 13 Aug 2015 23:20:20 +0000
> Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > I have no problem with ruling out the jobs/bg/fg callsites, as you
> > propose. However, checking (synch == 1) would also mean the value of
> > PRINTEXITVALUE is entirely ignored when printjob() is called
> > asynchronously. I can see that that is fine for jobs that don't have
> > STAT_NOPRINT set.¹ Is it also correct to ignore PRINTEXITVALUE in the
> > case (synch == 0 && (jn->stat & STAT_NOPRINT))?
>
> My point is really that you don't want to *modify* the code unless synch
> == 1. So sync == anything else should continue to do just what it does
> at the moment, but if synch == 1 you can apply your extra check. That
> seems likely to do the nearest to what everybody wants.
I'll give that a shot. (Was a bit busy so haven't coded it yet.)
Thanks again.
next prev parent reply other threads:[~2015-08-17 22:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 23:12 Daniel Shahaf
2015-08-13 8:32 ` Peter Stephenson
2015-08-13 23:20 ` Daniel Shahaf
2015-08-14 8:19 ` Peter Stephenson
2015-08-17 22:00 ` Daniel Shahaf [this message]
2015-08-15 1:04 ` Vincent Lefevre
2015-08-15 1:20 ` Mikael Magnusson
2015-08-19 0:06 ` Vincent Lefevre
2015-08-19 0:25 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150817220036.GB2283@tarsus.local2 \
--to=d.s@daniel.shahaf.name \
--cc=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).