zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: incorrect setopt completion
Date: Mon, 17 Aug 2015 22:02:21 +0000	[thread overview]
Message-ID: <20150817220221.GC2283@tarsus.local2> (raw)
In-Reply-To: <CAHYJk3RqWHvn3nBWmh16GvP0BNEDrekcpkcPTHtt0AHJMfN_iQ@mail.gmail.com>

Mikael Magnusson wrote on Sat, Aug 15, 2015 at 03:02:45 +0200:
> If anyone is very bored, they could make a separate variable that gets
> checked instead of / in addition to isset(PRINTEXITVALUE) in relevant
> places, and leave the value of the option alone, but for now I'll just
> do this.

I think my PRINT_EXIT_VALUE branch (discussed in another thread) does
this:

https://github.com/danielshahaf/zsh/commit/ba8c0a1afd5c000cbb86aa988e85bd8ba7cf99ff

> -onopts=( ${(k)_comp_caller_options[(R)on]} )
> +onopts=( ${(k)_comp_caller_options[(R)on]} printexitvalue )

I suggest a comment explaining why printexitvalue is special-cased.  (So
people don't have to run 'git blame' and then search the list archives.)


  reply	other threads:[~2015-08-17 22:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-15  0:05 Vincent Lefevre
2015-08-15  1:02 ` Mikael Magnusson
2015-08-17 22:02   ` Daniel Shahaf [this message]
2015-08-15  2:09 ` Bart Schaefer
2015-08-15  2:14   ` Mikael Magnusson
2015-08-16 22:55     ` Mikael Magnusson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150817220221.GC2283@tarsus.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).