From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: zsh-workers@zsh.org
Subject: Re: Two issues found with -fsanitize=undefined
Date: Sat, 19 Sep 2015 22:18:14 +0200 [thread overview]
Message-ID: <20150919201814.GA409@x4> (raw)
In-Reply-To: <20150919205751.5338bddc@ntlworld.com>
On 2015.09.19 at 20:57 +0100, Peter Stephenson wrote:
> On Thu, 17 Sep 2015 09:57:59 +0200
> Markus Trippelsdorf <markus@trippelsdorf.de> wrote:
> > 1)
> > pattern.c:2645:12: runtime error: signed integer overflow: 1234567890123456789 * 10 cannot be represented in type 'long int'
> > Test ./D02glob.ztst failed: error output differs from expected as shown above for:
>
> This might shut the compiler up, although the existing code should do
> the right thing anyway. I don't have gcc 5.
Thanks. It fixes one issue. And please note that all issues reported by
running the instrumented shell, build with -fsanitize=undefined, are
_real_ undefined behavior bugs. So this is not about shutting the
compiler up, but making sure that undefined behavior isn't invoked
anymore.
BTW clang's -fsanitize=undefined report these additional cases during
D02glob.ztst:
./D02glob.ztst: starting.
exec.c:2240:6: runtime error: index 8 out of bounds for type 'int [8]'
exec.c:2048:10: runtime error: index 8 out of bounds for type 'int [8]'
exec.c:2122:7: runtime error: index 8 out of bounds for type 'int [8]'
--
Markus
next prev parent reply other threads:[~2015-09-19 20:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 7:57 Markus Trippelsdorf
2015-09-17 17:16 ` Bart Schaefer
2015-09-17 17:24 ` Markus Trippelsdorf
2015-09-17 17:41 ` Bart Schaefer
2015-09-19 19:57 ` Peter Stephenson
2015-09-19 20:18 ` Markus Trippelsdorf [this message]
2015-09-19 22:35 ` Peter Stephenson
2015-09-20 4:09 ` Bart Schaefer
2015-09-21 12:46 ` Peter Stephenson
2015-09-21 19:13 ` Peter Stephenson
2015-09-21 20:04 ` Markus Trippelsdorf
2015-09-21 20:21 ` Peter Stephenson
2015-09-21 20:34 ` Markus Trippelsdorf
2015-09-21 20:56 ` Bart Schaefer
2015-09-22 0:02 ` Markus Trippelsdorf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150919201814.GA409@x4 \
--to=markus@trippelsdorf.de \
--cc=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).